fix(ts): properly disconnect wallet connect

[gregfromstl]

PR-Codex overview

This PR focuses on fixing WalletConnect client disconnections and improving error handling.

Detailed summary

• Added delay before expecting disconnection in tests
• Improved error handling in disconnectWalletConnectSession
• Added onDisconnect function in WalletConnectReceiverScreen
• Added no-op catch for already disconnected state in disconnect function

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
thirdweb_playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 28, 2024 10:04pm
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 28, 2024 10:04pm

[changeset-bot[bot]]

🦋 Changeset detected

Latest commit: 85f2f6d2bd61364ee1b66609f51dcaded0eba790

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | -------- | ----- | | thirdweb | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[graphite-app[bot]]

Your org requires the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

[gregfromstl]

• #3541
• #3539 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @gregfromstl and the rest of your teammates on Graphite

[codspeed-hq[bot]]

CodSpeed Performance Report

Merging #3539 will not alter performance

_{Comparing fix/wallet-connect-disconnection (85f2f6d) with main (6704fa8)}

Summary

✅ 9 untouched benchmarks

[github-actions[bot]]

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	40.8 KB (0%)	816 ms (0%)	4 s (-0.08% 🔽)	4.8 s
thirdweb (cjs)	91.95 KB (0%)	1.9 s (0%)	8.4 s (-8.25% 🔽)	10.3 s
thirdweb (minimal + tree-shaking)	4.79 KB (0%)	96 ms (0%)	366 ms (+27.8% 🔺)	462 ms
thirdweb/chains (tree-shaking)	423 B (0%)	10 ms (0%)	118 ms (-6.03% 🔽)	128 ms
thirdweb/react (minimal + tree-shaking)	13.51 KB (0%)	271 ms (0%)	454 ms (-25.77% 🔽)	724 ms

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 57.14286% with 6 lines in your changes missing coverage. Please review.

Project coverage is 62.67%. Comparing base (6704fa8) to head (85f2f6d).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #3539 +/- ## ========================================== + Coverage 62.46% 62.67% +0.20% ========================================== Files 897 896 -1 Lines 68782 68520 -262 Branches 3669 3674 +5 ========================================== - Hits 42968 42942 -26 + Misses 25128 24892 -236 Partials 686 686 ``` | [Flag](https://app.codecov.io/gh/thirdweb-dev/js/pull/3539/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | Coverage Δ | | *Carryforward flag | |---|---|---|---| | [legacy_packages](https://app.codecov.io/gh/thirdweb-dev/js/pull/3539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | `65.59% <ø> (ø)` | | Carriedforward from [6704fa8](https://app.codecov.io/gh/thirdweb-dev/js/commit/6704fa887013322e23cb0b7a5d96b3cf647ce8c5?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | | [packages](https://app.codecov.io/gh/thirdweb-dev/js/pull/3539/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | `62.11% <57.14%> (+0.23%)` | :arrow_up: | | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) to find out more. | [Files](https://app.codecov.io/gh/thirdweb-dev/js/pull/3539?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | Coverage Δ | | |---|---|---| | [...rdweb/src/wallets/wallet-connect/receiver/index.ts](https://app.codecov.io/gh/thirdweb-dev/js/pull/3539?src=pr&el=tree&filepath=packages%2Fthirdweb%2Fsrc%2Fwallets%2Fwallet-connect%2Freceiver%2Findex.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev#diff-cGFja2FnZXMvdGhpcmR3ZWIvc3JjL3dhbGxldHMvd2FsbGV0LWNvbm5lY3QvcmVjZWl2ZXIvaW5kZXgudHM=) | `92.75% <100.00%> (+0.10%)` | :arrow_up: | | [...nectWallet/screens/WalletConnectReceiverScreen.tsx](https://app.codecov.io/gh/thirdweb-dev/js/pull/3539?src=pr&el=tree&filepath=packages%2Fthirdweb%2Fsrc%2Freact%2Fweb%2Fui%2FConnectWallet%2Fscreens%2FWalletConnectReceiverScreen.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev#diff-cGFja2FnZXMvdGhpcmR3ZWIvc3JjL3JlYWN0L3dlYi91aS9Db25uZWN0V2FsbGV0L3NjcmVlbnMvV2FsbGV0Q29ubmVjdFJlY2VpdmVyU2NyZWVuLnRzeA==) | `11.92% <0.00%> (-0.34%)` | :arrow_down: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/thirdweb-dev/js/pull/3539/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev)

[graphite-app[bot]]

Merge activity

• Jun 28, 5:49 PM EDT: gregfromstl added this pull request to the Graphite merge queue.
• Jun 28, 6:04 PM EDT: gregfromstl merged this pull request with the Graphite merge queue.