thirdweb-dev / js

Best in class web3 SDKs for Browser, Node and Mobile apps
https://thirdweb.com
Apache License 2.0
379 stars 259 forks source link

fix(wallet): handle errors when connecting with open access ecosystem #3545

Closed gregfromstl closed 1 week ago

gregfromstl commented 1 week ago

PR-Codex overview

This PR fixes errors related to connecting with an open access ecosystem in the in-app-account.ts file.

Detailed summary

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2024 10:45pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2024 10:45pm
changeset-bot[bot] commented 1 week ago

🦋 Changeset detected

Latest commit: 7e242602e91565c62d7db1e9ba042405ac66dbc6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------- | ----- | | thirdweb | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

graphite-app[bot] commented 1 week ago

Your org requires the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

gregfromstl commented 1 week ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @gregfromstl and the rest of your teammates on Graphite Graphite

codspeed-hq[bot] commented 1 week ago

CodSpeed Performance Report

Merging #3545 will not alter performance

Comparing fix/in-app-wallet-permissions (7e24260) with main (85f2f6d)

Summary

✅ 9 untouched benchmarks

github-actions[bot] commented 1 week ago

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 40.8 KB (0%) 816 ms (0%) 1.1 s (+43.14% 🔺) 1.9 s
thirdweb (cjs) 91.95 KB (0%) 1.9 s (0%) 1.8 s (+3.04% 🔺) 3.7 s
thirdweb (minimal + tree-shaking) 4.79 KB (0%) 96 ms (0%) 283 ms (+383.91% 🔺) 379 ms
thirdweb/chains (tree-shaking) 423 B (0%) 10 ms (0%) 278 ms (+2022.99% 🔺) 288 ms
thirdweb/react (minimal + tree-shaking) 13.51 KB (0%) 271 ms (0%) 167 ms (+25.12% 🔺) 437 ms
codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 62.70%. Comparing base (85f2f6d) to head (7e24260).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3545 +/- ## ========================================== + Coverage 62.67% 62.70% +0.03% ========================================== Files 896 896 Lines 68520 68520 Branches 3674 3683 +9 ========================================== + Hits 42942 42964 +22 + Misses 24892 24870 -22 Partials 686 686 ``` | [Flag](https://app.codecov.io/gh/thirdweb-dev/js/pull/3545/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | Coverage Δ | | *Carryforward flag | |---|---|---|---| | [legacy_packages](https://app.codecov.io/gh/thirdweb-dev/js/pull/3545/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | `65.59% <ø> (ø)` | | Carriedforward from [85f2f6d](https://app.codecov.io/gh/thirdweb-dev/js/commit/85f2f6d2bd61364ee1b66609f51dcaded0eba790?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | | [packages](https://app.codecov.io/gh/thirdweb-dev/js/pull/3545/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | `62.15% <ø> (+0.03%)` | :arrow_up: | | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) to find out more. [see 9 files with indirect coverage changes](https://app.codecov.io/gh/thirdweb-dev/js/pull/3545/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev)
graphite-app[bot] commented 1 week ago

Merge activity