[Fix] Update import paths in engine-explorer and _app.tsx for better modularity

jnsdls commented 1 week ago

TL;DR

Corrected stylesheet imports for swagger-ui.css in the Engine Explorer component and added the Toaster component import in the _app.tsx.

What changed?

Added missing swagger-ui.css import in engine-explorer.tsx
Removed duplicate swagger-ui.css import from _app.tsx
Ensured Toaster component import in _app.tsx

How to test?

Verify UI for the Engine Explorer relies on the correct styles
Ensure the Toaster component renders correctly without issues

Why make this change?

To ensure the correct CSS styles are applied and to improve the maintainability of the import statements.

PR-Codex overview

The focus of this PR is to add a new CSS file for Swagger UI styling and remove unnecessary CSS imports.

Detailed summary

Added apps/dashboard/src/components/engine/explorer/engine-explorer.tsx with import of swagger-ui.css
Removed import of css/swagger-ui.css from apps/dashboard/src/pages/_app.tsx

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
thirdweb_playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 28, 2024 11:19pm
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 28, 2024 11:19pm

changeset-bot[bot] commented 1 week ago

⚠️ No Changeset found

Latest commit: 3ffad1a5a69e248bb023c0c4ca1963441e634f07

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

graphite-app[bot] commented 1 week ago

Your org requires the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

jnsdls commented 1 week ago

#3547 👈
#3546
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jnsdls and the rest of your teammates on Graphite

codspeed-hq[bot] commented 1 week ago

CodSpeed Performance Report

Merging #3547 will not alter performance

_{Comparing fix/update-imports-in-dashboard-components (3ffad1a) with feature/update-dependencies-and-new-components (37d9373)}

Summary

✅ 9 untouched benchmarks

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 62.48%. Comparing base (37d9373) to head (3ffad1a).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## feature/update-dependencies-and-new-components #3547 +/- ## =============================================================================== Coverage 62.48% 62.48% =============================================================================== Files 897 897 Lines 68814 68814 Branches 3670 3670 =============================================================================== Hits 42996 42996 Misses 25130 25130 Partials 688 688 ``` | [Flag](https://app.codecov.io/gh/thirdweb-dev/js/pull/3547/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | Coverage Δ | | *Carryforward flag | |---|---|---|---| | [legacy_packages](https://app.codecov.io/gh/thirdweb-dev/js/pull/3547/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | `65.59% <ø> (ø)` | | Carriedforward from [37d9373](https://app.codecov.io/gh/thirdweb-dev/js/commit/37d9373cf21e26527e51812d343bef8d49fe08ed?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | | [packages](https://app.codecov.io/gh/thirdweb-dev/js/pull/3547/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | `61.89% <ø> (ø)` | | | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) to find out more.

github-actions[bot] commented 1 week ago

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	40.8 KB (0%)	816 ms (0%)	1.1 s (+12.86% 🔺)	1.9 s
thirdweb (cjs)	91.95 KB (0%)	1.9 s (0%)	1.5 s (-24.74% 🔽)	3.4 s
thirdweb (minimal + tree-shaking)	4.79 KB (0%)	96 ms (0%)	244 ms (+498.47% 🔺)	340 ms
thirdweb/chains (tree-shaking)	423 B (0%)	10 ms (0%)	53 ms (+89.1% 🔺)	63 ms
thirdweb/react (minimal + tree-shaking)	13.51 KB (0%)	271 ms (0%)	82 ms (-32.83% 🔽)	353 ms

graphite-app[bot] commented 1 week ago

Merge activity

Jun 28, 6:37 PM EDT: jnsdls added this pull request to the Graphite merge queue.
Jun 28, 7:20 PM EDT: jnsdls merged this pull request with the Graphite merge queue.

thirdweb-dev / js