search

thirdweb-dev / js

Best in class web3 SDKs for Browser, Node and Mobile apps
https://thirdweb.com
Apache License 2.0
379 stars 259 forks source link

chore(tests): update tests to use sendAndConfirmTransaction method #3548

Closed gregfromstl closed 6 days ago

gregfromstl commented 1 week ago

This pull request updates the function names and constants used in the deploy-modular-core.test.ts file. Specific changes include:

TL;DR

Updated function names and constants in the deploy-modular-core.test.ts for better alignment with the codebase.

What changed?

How to test?

Run the updated tests in deploy-modular-core.test.ts to ensure all changes work as expected.

Why make this change?

These changes improve the code readability and follow naming conventions already established in the codebase. By including transaction confirmation, the tests are more robust and reliable.

PR-Codex overview

The focus of this PR is to update the transaction handling in the deploy-modular-core.test.ts test file by replacing sendTransaction with sendAndConfirmTransaction.

Detailed summary

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 29, 2024 4:04am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 29, 2024 4:04am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 29, 2024 4:04am
changeset-bot[bot] commented 1 week ago

⚠️ No Changeset found

Latest commit: 80b9cd967c61e6568bccb1cb5c2f182bc06048eb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

graphite-app[bot] commented 1 week ago

Your org requires the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

gregfromstl commented 1 week ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @gregfromstl and the rest of your teammates on Graphite Graphite

codspeed-hq[bot] commented 1 week ago

CodSpeed Performance Report

Merging #3548 will improve performances by 13.67%

Comparing chore/tests/update-zero-address-and-transaction-methods (80b9cd9) with main (cddd0ca)

Summary

⚡ 1 improvements ✅ 8 untouched benchmarks

Benchmarks breakdown

Benchmark main chore/tests/update-zero-address-and-transaction-methods Change
⚡ keccakId 1.5 ms 1.3 ms +13.67%
github-actions[bot] commented 1 week ago

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 40.47 KB (0%) 810 ms (0%) 902 ms (+7.14% 🔺) 1.8 s
thirdweb (cjs) 89.99 KB (0%) 1.8 s (0%) 1.6 s (+4.64% 🔺) 3.4 s
thirdweb (minimal + tree-shaking) 4.79 KB (0%) 96 ms (0%) 46 ms (-29.35% 🔽) 142 ms
thirdweb/chains (tree-shaking) 423 B (0%) 10 ms (0%) 33 ms (+122.27% 🔺) 43 ms
thirdweb/react (minimal + tree-shaking) 13.52 KB (0%) 271 ms (0%) 301 ms (+115.82% 🔺) 572 ms
codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 62.49%. Comparing base (cddd0ca) to head (80b9cd9).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3548 +/- ## ========================================== + Coverage 62.30% 62.49% +0.18% ========================================== Files 900 899 -1 Lines 69102 68843 -259 Branches 3684 3670 -14 ========================================== - Hits 43055 43024 -31 + Misses 25358 25131 -227 + Partials 689 688 -1 ``` | [Flag](https://app.codecov.io/gh/thirdweb-dev/js/pull/3548/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | Coverage Δ | | *Carryforward flag | |---|---|---|---| | [legacy_packages](https://app.codecov.io/gh/thirdweb-dev/js/pull/3548/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | `65.59% <ø> (ø)` | | Carriedforward from [cddd0ca](https://app.codecov.io/gh/thirdweb-dev/js/commit/cddd0ca3025a9d0be7576498f1ad6a34a5c3684f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | | [packages](https://app.codecov.io/gh/thirdweb-dev/js/pull/3548/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | `61.91% <ø> (+0.22%)` | :arrow_up: | | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) to find out more. [see 5 files with indirect coverage changes](https://app.codecov.io/gh/thirdweb-dev/js/pull/3548/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev)
graphite-app[bot] commented 6 days ago

Merge activity