Add NetworkSwitcher in v5, use in dashboard

MananTank commented 3 months ago

Problem solved

Short description of the bug fixed or feature added

Changes made

[ ] Public API changes: list the public API changes made if any
[ ] Internal API changes: explain the internal logic changes

How to test

[ ] Automated tests: link to unit test file
[ ] Manual tests: step by step instructions on how to test

Contributor NFT

Paste in your wallet address below and we will airdrop you a special NFT when your pull request is merged.

Address:

PR-Codex overview

This PR introduces changes across multiple files to disable focus trapping and scroll blocking in various components.

Detailed summary

Disabled focus trapping and scroll blocking in Modal, Drawer, and other components
Added CustomChainRenderer in CustomConnectWallet
Updated NetworkSelectorButton to use CustomChainRenderer
Implemented mapStoredChainTov5Chain function for mapping chains

The following files were skipped due to too many changes: packages/thirdweb/src/react/web/ui/ConnectWallet/NetworkSelector.tsx

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 29, 2024 0:43am
wallet-ui	🛑 Canceled (Inspect)			Jun 29, 2024 0:43am

1 Ignored Deployment

changeset-bot[bot] commented 3 months ago

⚠️ No Changeset found

Latest commit: 302969c8013c4e3da2c05b481d15763d8a4c9e0a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

graphite-app[bot] commented 3 months ago

Your org requires the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

MananTank commented 3 months ago

[!WARNING] This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite. Learn more

#3549 👈
#3397
#3392 : 3 other dependent PRs (#3393 , #3395 , #3396 )
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite

MananTank commented 3 months ago

Need to check something - On local the Network list was not scrollable when the NetworkSwitcher button is used in Deploy page. Need to check this in vercel preview to confirm

codspeed-hq[bot] commented 3 months ago

CodSpeed Performance Report

Merging #3549 will not alter performance

_{Comparing 06-29-add_networkswitcher_in_v5_use_in_dashboard (302969c) with refactor/connect-wallet-cleanup (d57c4f9)}

Summary

✅ 9 untouched benchmarks

github-actions[bot] commented 3 months ago

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	40.86 KB (0%)	818 ms (0%)	2.8 s (+27.9% 🔺)	3.7 s
thirdweb (cjs)	92.02 KB (0%)	1.9 s (0%)	7.3 s (+25.45% 🔺)	9.1 s
thirdweb (minimal + tree-shaking)	4.82 KB (0%)	97 ms (0%)	428 ms (+201.69% 🔺)	524 ms
thirdweb/chains (tree-shaking)	433 B (0%)	10 ms (0%)	200 ms (+163.72% 🔺)	210 ms
thirdweb/react (minimal + tree-shaking)	13.51 KB (0%)	271 ms (0%)	593 ms (+40.46% 🔺)	863 ms

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 71.03825% with 53 lines in your changes missing coverage. Please review.

Project coverage is 62.67%. Comparing base (d57c4f9) to head (302969c).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## refactor/connect-wallet-cleanup #3549 +/- ## =================================================================== + Coverage 62.63% 62.67% +0.03% =================================================================== Files 895 895 Lines 68356 68534 +178 Branches 3655 3657 +2 =================================================================== + Hits 42818 42951 +133 - Misses 24850 24895 +45 Partials 688 688 ``` | [Flag](https://app.codecov.io/gh/thirdweb-dev/js/pull/3549/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | Coverage Δ | | *Carryforward flag | |---|---|---|---| | [legacy_packages](https://app.codecov.io/gh/thirdweb-dev/js/pull/3549/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | `65.59% <ø> (ø)` | | Carriedforward from [5b24fd1](https://app.codecov.io/gh/thirdweb-dev/js/commit/5b24fd10b9f72e577c4c547e7ebe83b8fd7fce09?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | | [packages](https://app.codecov.io/gh/thirdweb-dev/js/pull/3549/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | `62.11% <71.03%> (+0.03%)` | :arrow_up: | | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) to find out more. | [Files](https://app.codecov.io/gh/thirdweb-dev/js/pull/3549?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | Coverage Δ | | |---|---|---| | [...src/react/web/ui/ConnectWallet/NetworkSelector.tsx](https://app.codecov.io/gh/thirdweb-dev/js/pull/3549?src=pr&el=tree&filepath=packages%2Fthirdweb%2Fsrc%2Freact%2Fweb%2Fui%2FConnectWallet%2FNetworkSelector.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev#diff-cGFja2FnZXMvdGhpcmR3ZWIvc3JjL3JlYWN0L3dlYi91aS9Db25uZWN0V2FsbGV0L05ldHdvcmtTZWxlY3Rvci50c3g=) | `33.44% <71.03%> (+8.97%)` | :arrow_up: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/thirdweb-dev/js/pull/3549/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev)

thirdweb-dev / js