feat(dashboard): ecosystem wallet pages loading states

gregfromstl commented 3 months ago

TL;DR

Remove Spinner components and add skeleton loaders, improve error handling in Ecosystem feature.

What changed?

Removed Spinner components from various Ecosystem-related parts
Added Skeleton components for loading states
Improved error handling by adding invariant checks and conditional rendering
Minor layout improvements and comments for future improvements

How to test?

Navigate to different Ecosystem pages and ensure loaders appear correctly when data is being fetched
Verify that error handling works by trying to access non-existent Ecosystem or updating without proper data

Why make this change?

To provide a more polished and user-friendly loading experience and to enhance error handling in the Ecosystem feature.

PR-Codex overview

The focus of this PR is to enhance ecosystem management in the dashboard by improving partner form layout, adding access token check, and updating sidebar styling.

Detailed summary

Added access token check to redirect unauthorized users
Updated partner form layout for better usability
Improved sidebar styling for responsiveness and layout consistency

The following files were skipped due to too many changes: apps/dashboard/src/app/(dashboard)/dashboard/connect/ecosystem/page.tsx, apps/dashboard/src/app/(dashboard)/dashboard/connect/ecosystem/[ecosystemId]/components/server/partners-table.tsx, apps/dashboard/src/app/(dashboard)/dashboard/connect/ecosystem/[ecosystemId]/components/client/ecosystem-header.client.tsx

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
thirdweb-www	❌ Failed (Inspect)			Jul 1, 2024 0:35am

2 Ignored Deployments

changeset-bot[bot] commented 3 months ago

⚠️ No Changeset found

Latest commit: 9689db29bd80e6a9800262b725c3f6e64438828c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

graphite-app[bot] commented 3 months ago

Your org requires the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

gregfromstl commented 3 months ago

[!WARNING] This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite. Learn more

#3557
#3556 👈
#3537 : 1 other dependent PR (#3535 )
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @gregfromstl and the rest of your teammates on Graphite

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 62.31%. Comparing base (946b58a) to head (6c6524f).

:exclamation: Current head 6c6524f differs from pull request most recent head 9689db2

Please upload reports for the commit 9689db2 to get more accurate results.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## feature/ecosystem-create-form #3556 +/- ## ============================================================== Coverage 62.31% 62.31% ============================================================== Files 900 900 Lines 69102 69102 Branches 3682 3682 ============================================================== Hits 43058 43058 Misses 25356 25356 Partials 688 688 ``` | [Flag](https://app.codecov.io/gh/thirdweb-dev/js/pull/3556/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | Coverage Δ | | *Carryforward flag | |---|---|---|---| | [legacy_packages](https://app.codecov.io/gh/thirdweb-dev/js/pull/3556/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | `65.59% <ø> (ø)` | | Carriedforward from [946b58a](https://app.codecov.io/gh/thirdweb-dev/js/commit/946b58a2e45ee441e90296af95499100fd353338?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | | [packages](https://app.codecov.io/gh/thirdweb-dev/js/pull/3556/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | `61.69% <ø> (ø)` | | | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) to find out more.

codspeed-hq[bot] commented 3 months ago

CodSpeed Performance Report

Merging #3556 will not alter performance

_{Comparing feature/loading-states (9689db2) with feature/loading-states (6c6524f)}

Summary

✅ 9 untouched benchmarks

github-actions[bot] commented 3 months ago

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	40.47 KB (0%)	810 ms (0%)	3.6 s (-16.78% 🔽)	4.4 s
thirdweb (cjs)	89.99 KB (0%)	1.8 s (0%)	5.6 s (-12.69% 🔽)	7.4 s
thirdweb (minimal + tree-shaking)	4.79 KB (0%)	96 ms (0%)	212 ms (+67.53% 🔺)	308 ms
thirdweb/chains (tree-shaking)	423 B (0%)	10 ms (0%)	109 ms (+4.51% 🔺)	119 ms
thirdweb/react (minimal + tree-shaking)	13.52 KB (0%)	271 ms (0%)	662 ms (+97.98% 🔺)	932 ms

thirdweb-dev / js