search

thirdweb-dev / js

Best in class web3 SDKs for Browser, Node and Mobile apps
https://thirdweb.com
Apache License 2.0
428 stars 324 forks source link

fix: add missing sendTransaction import in multiple files to ensure proper transaction handling #3559

Closed joaquim-verges closed 3 months ago

joaquim-verges commented 3 months ago

PR-Codex overview

This PR adds documentation annotations to functions across different files for better code readability and understanding.

Detailed summary

The following files were skipped due to too many changes: packages/thirdweb/src/extensions/marketplace/direct-listings/write/createListing.ts, packages/thirdweb/src/extensions/marketplace/direct-listings/write/updateListing.ts, packages/thirdweb/src/extensions/marketplace/english-auctions/write/createAuction.ts, packages/thirdweb/src/extensions/erc20/write/transferFrom.ts, packages/thirdweb/src/extensions/erc1155/drops/write/claimTo.ts, packages/thirdweb/src/extensions/farcaster/write/addSignerFor.ts, packages/thirdweb/src/extensions/marketplace/direct-listings/write/buyFromListing.ts, packages/thirdweb/src/extensions/erc20/drops/write/claimTo.ts, packages/thirdweb/src/extensions/erc721/drops/write/claimTo.ts, packages/thirdweb/src/extensions/erc721/write/lazyMint.ts, packages/thirdweb/src/extensions/erc1155/write/lazyMint.ts, packages/thirdweb/src/extensions/erc4337/account/addSessionKey.ts, packages/thirdweb/src/extensions/erc20/drops/write/setClaimConditions.ts, packages/thirdweb/src/extensions/erc721/drops/write/setClaimConditions.ts, packages/thirdweb/src/extensions/erc1155/drops/write/setClaimConditions.ts, packages/thirdweb/src/extensions/erc1155/write/mintAdditionalSupplyTo.ts, packages/thirdweb/src/extensions/farcaster/write/registerFidAndSigner.ts, packages/thirdweb/src/extensions/erc721/write/mintTo.ts, packages/thirdweb/src/extensions/permissions/write/renounceRole.ts, packages/thirdweb/src/extensions/erc1155/write/mintTo.ts, packages/thirdweb/src/extensions/permissions/write/grant.ts, packages/thirdweb/src/extensions/permissions/write/revokeRole.ts, packages/thirdweb/src/react/core/hooks/transaction/useSimulateTransaction.ts, packages/thirdweb/src/extensions/marketplace/offers/write/makeOffer.ts, packages/thirdweb/src/extensions/erc20/write/deposit.ts, packages/thirdweb/src/wallets/wallet-connect/receiver/index.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2024 7:55am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2024 7:55am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2024 7:55am
changeset-bot[bot] commented 3 months ago

⚠️ No Changeset found

Latest commit: f0f50914740bef8810257e9e3c99f887b50c6a56

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

graphite-app[bot] commented 3 months ago

Your org requires the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

joaquim-verges commented 3 months ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on Graphite Graphite

codspeed-hq[bot] commented 3 months ago

CodSpeed Performance Report

Merging #3559 will not alter performance

Comparing fix/add-sendTransaction-imports (f0f5091) with main (54c1789)

Summary

✅ 9 untouched benchmarks

github-actions[bot] commented 3 months ago

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 40.47 KB (0%) 810 ms (0%) 915 ms (-0.97% 🔽) 1.8 s
thirdweb (cjs) 89.99 KB (0%) 1.8 s (0%) 1.6 s (-19.43% 🔽) 3.4 s
thirdweb (minimal + tree-shaking) 4.79 KB (0%) 96 ms (0%) 219 ms (+418.68% 🔺) 314 ms
thirdweb/chains (tree-shaking) 423 B (0%) 10 ms (0%) 265 ms (+815.79% 🔺) 275 ms
thirdweb/react (minimal + tree-shaking) 13.52 KB (0%) 271 ms (0%) 109 ms (-67.81% 🔽) 380 ms
codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 62.35%. Comparing base (54c1789) to head (f0f5091).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3559 +/- ## ========================================== - Coverage 62.73% 62.35% -0.38% ========================================== Files 898 900 +2 Lines 68570 69196 +626 Branches 3685 3683 -2 ========================================== + Hits 43018 43149 +131 - Misses 24863 25358 +495 Partials 689 689 ``` | [Flag](https://app.codecov.io/gh/thirdweb-dev/js/pull/3559/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | Coverage Δ | | *Carryforward flag | |---|---|---|---| | [legacy_packages](https://app.codecov.io/gh/thirdweb-dev/js/pull/3559/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | `65.59% <ø> (ø)` | | Carriedforward from [54c1789](https://app.codecov.io/gh/thirdweb-dev/js/commit/54c17893307ea4dac13894cb3e07d82821a6012f?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | | [packages](https://app.codecov.io/gh/thirdweb-dev/js/pull/3559/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | `61.75% <100.00%> (-0.45%)` | :arrow_down: | | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) to find out more. | [Files](https://app.codecov.io/gh/thirdweb-dev/js/pull/3559?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | Coverage Δ | | |---|---|---| | [...ages/thirdweb/src/contract/deployment/publisher.ts](https://app.codecov.io/gh/thirdweb-dev/js/pull/3559?src=pr&el=tree&filepath=packages%2Fthirdweb%2Fsrc%2Fcontract%2Fdeployment%2Fpublisher.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev#diff-cGFja2FnZXMvdGhpcmR3ZWIvc3JjL2NvbnRyYWN0L2RlcGxveW1lbnQvcHVibGlzaGVyLnRz) | `82.90% <100.00%> (+0.06%)` | :arrow_up: | | [...sions/airdrop/write/airdropERC1155WithSignature.ts](https://app.codecov.io/gh/thirdweb-dev/js/pull/3559?src=pr&el=tree&filepath=packages%2Fthirdweb%2Fsrc%2Fextensions%2Fairdrop%2Fwrite%2FairdropERC1155WithSignature.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev#diff-cGFja2FnZXMvdGhpcmR3ZWIvc3JjL2V4dGVuc2lvbnMvYWlyZHJvcC93cml0ZS9haXJkcm9wRVJDMTE1NVdpdGhTaWduYXR1cmUudHM=) | `100.00% <100.00%> (ø)` | | | [...ensions/airdrop/write/airdropERC20WithSignature.ts](https://app.codecov.io/gh/thirdweb-dev/js/pull/3559?src=pr&el=tree&filepath=packages%2Fthirdweb%2Fsrc%2Fextensions%2Fairdrop%2Fwrite%2FairdropERC20WithSignature.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev#diff-cGFja2FnZXMvdGhpcmR3ZWIvc3JjL2V4dGVuc2lvbnMvYWlyZHJvcC93cml0ZS9haXJkcm9wRVJDMjBXaXRoU2lnbmF0dXJlLnRz) | `100.00% <100.00%> (ø)` | | | [...nsions/airdrop/write/airdropERC721WithSignature.ts](https://app.codecov.io/gh/thirdweb-dev/js/pull/3559?src=pr&el=tree&filepath=packages%2Fthirdweb%2Fsrc%2Fextensions%2Fairdrop%2Fwrite%2FairdropERC721WithSignature.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev#diff-cGFja2FnZXMvdGhpcmR3ZWIvc3JjL2V4dGVuc2lvbnMvYWlyZHJvcC93cml0ZS9haXJkcm9wRVJDNzIxV2l0aFNpZ25hdHVyZS50cw==) | `100.00% <100.00%> (ø)` | | | [...rdweb/src/extensions/airdrop/write/claimERC1155.ts](https://app.codecov.io/gh/thirdweb-dev/js/pull/3559?src=pr&el=tree&filepath=packages%2Fthirdweb%2Fsrc%2Fextensions%2Fairdrop%2Fwrite%2FclaimERC1155.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev#diff-cGFja2FnZXMvdGhpcmR3ZWIvc3JjL2V4dGVuc2lvbnMvYWlyZHJvcC93cml0ZS9jbGFpbUVSQzExNTUudHM=) | `95.52% <100.00%> (+0.06%)` | :arrow_up: | | [...hirdweb/src/extensions/airdrop/write/claimERC20.ts](https://app.codecov.io/gh/thirdweb-dev/js/pull/3559?src=pr&el=tree&filepath=packages%2Fthirdweb%2Fsrc%2Fextensions%2Fairdrop%2Fwrite%2FclaimERC20.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev#diff-cGFja2FnZXMvdGhpcmR3ZWIvc3JjL2V4dGVuc2lvbnMvYWlyZHJvcC93cml0ZS9jbGFpbUVSQzIwLnRz) | `91.01% <100.00%> (+0.10%)` | :arrow_up: | | [...irdweb/src/extensions/airdrop/write/claimERC721.ts](https://app.codecov.io/gh/thirdweb-dev/js/pull/3559?src=pr&el=tree&filepath=packages%2Fthirdweb%2Fsrc%2Fextensions%2Fairdrop%2Fwrite%2FclaimERC721.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev#diff-cGFja2FnZXMvdGhpcmR3ZWIvc3JjL2V4dGVuc2lvbnMvYWlyZHJvcC93cml0ZS9jbGFpbUVSQzcyMS50cw==) | `95.45% <100.00%> (+0.06%)` | :arrow_up: | | [...dweb/src/extensions/erc1155/drops/write/claimTo.ts](https://app.codecov.io/gh/thirdweb-dev/js/pull/3559?src=pr&el=tree&filepath=packages%2Fthirdweb%2Fsrc%2Fextensions%2Ferc1155%2Fdrops%2Fwrite%2FclaimTo.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev#diff-cGFja2FnZXMvdGhpcmR3ZWIvc3JjL2V4dGVuc2lvbnMvZXJjMTE1NS9kcm9wcy93cml0ZS9jbGFpbVRvLnRz) | `100.00% <100.00%> (ø)` | | | [...tensions/erc1155/drops/write/setClaimConditions.ts](https://app.codecov.io/gh/thirdweb-dev/js/pull/3559?src=pr&el=tree&filepath=packages%2Fthirdweb%2Fsrc%2Fextensions%2Ferc1155%2Fdrops%2Fwrite%2FsetClaimConditions.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev#diff-cGFja2FnZXMvdGhpcmR3ZWIvc3JjL2V4dGVuc2lvbnMvZXJjMTE1NS9kcm9wcy93cml0ZS9zZXRDbGFpbUNvbmRpdGlvbnMudHM=) | `100.00% <100.00%> (ø)` | | | [...c/extensions/erc1155/drops/write/updateMetadata.ts](https://app.codecov.io/gh/thirdweb-dev/js/pull/3559?src=pr&el=tree&filepath=packages%2Fthirdweb%2Fsrc%2Fextensions%2Ferc1155%2Fdrops%2Fwrite%2FupdateMetadata.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev#diff-cGFja2FnZXMvdGhpcmR3ZWIvc3JjL2V4dGVuc2lvbnMvZXJjMTE1NS9kcm9wcy93cml0ZS91cGRhdGVNZXRhZGF0YS50cw==) | `95.31% <100.00%> (+0.11%)` | :arrow_up: | | ... and [36 more](https://app.codecov.io/gh/thirdweb-dev/js/pull/3559?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/thirdweb-dev/js/pull/3559/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev)