Closed edwardysun closed 3 days ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
thirdweb_playground | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jul 2, 2024 5:34am |
thirdweb-www | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jul 2, 2024 5:34am |
wallet-ui | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jul 2, 2024 5:34am |
Latest commit: e5f772dd5c69e818bd17496a960d64775f9ffccc
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.
You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.
Comparing pay-domain-support-localhost
(e5f772d) with main
(373ce19)
✅ 9
untouched benchmarks
Path | Size | Loading time (3g) | Running time (snapdragon) | Total time |
---|---|---|---|---|
thirdweb (esm) | 40.55 KB (+0.21% 🔺) | 812 ms (+0.21% 🔺) | 1.5 s (+124.07% 🔺) | 2.4 s |
thirdweb (cjs) | 90.02 KB (+0.04% 🔺) | 1.9 s (+0.04% 🔺) | 2.1 s (+3.64% 🔺) | 3.9 s |
thirdweb (minimal + tree-shaking) | 4.79 KB (0%) | 96 ms (0%) | 554 ms (+878.38% 🔺) | 650 ms |
thirdweb/chains (tree-shaking) | 423 B (0%) | 10 ms (0%) | 400 ms (+2492.28% 🔺) | 410 ms |
thirdweb/react (minimal + tree-shaking) | 13.55 KB (0%) | 271 ms (0%) | 612 ms (+153.32% 🔺) | 883 ms |
Attention: Patch coverage is 43.75000%
with 9 lines
in your changes missing coverage. Please review.
Project coverage is 62.57%. Comparing base (
373ce19
) to head (e5f772d
).
jnsdls
added this pull request to the Graphite merge queue.jnsdls
merged this pull request with the Graphite merge queue.
Problem solved
Use "http://" if localhost domain used for thirdweb Pay
PR-Codex overview
This PR adds support for using localhost as a domain override option for the Pay service.
Detailed summary
getPayBaseUrl
function for constructing URLsgetPayBaseUrl
function for consistency