thirdweb-dev / js

Best in class web3 SDKs for Browser, Node and Mobile apps
https://thirdweb.com
Apache License 2.0
379 stars 259 forks source link

Support localhost in Pay domains #3569

Closed edwardysun closed 3 days ago

edwardysun commented 4 days ago

Problem solved

Use "http://" if localhost domain used for thirdweb Pay


PR-Codex overview

This PR adds support for using localhost as a domain override option for the Pay service.

Detailed summary

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

vercel[bot] commented 4 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2024 5:34am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2024 5:34am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2024 5:34am
changeset-bot[bot] commented 4 days ago

🦋 Changeset detected

Latest commit: e5f772dd5c69e818bd17496a960d64775f9ffccc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------- | ----- | | thirdweb | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

graphite-app[bot] commented 4 days ago

Your org requires the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

codspeed-hq[bot] commented 4 days ago

CodSpeed Performance Report

Merging #3569 will not alter performance

Comparing pay-domain-support-localhost (e5f772d) with main (373ce19)

Summary

✅ 9 untouched benchmarks

github-actions[bot] commented 4 days ago

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 40.55 KB (+0.21% 🔺) 812 ms (+0.21% 🔺) 1.5 s (+124.07% 🔺) 2.4 s
thirdweb (cjs) 90.02 KB (+0.04% 🔺) 1.9 s (+0.04% 🔺) 2.1 s (+3.64% 🔺) 3.9 s
thirdweb (minimal + tree-shaking) 4.79 KB (0%) 96 ms (0%) 554 ms (+878.38% 🔺) 650 ms
thirdweb/chains (tree-shaking) 423 B (0%) 10 ms (0%) 400 ms (+2492.28% 🔺) 410 ms
thirdweb/react (minimal + tree-shaking) 13.55 KB (0%) 271 ms (0%) 612 ms (+153.32% 🔺) 883 ms
codecov[bot] commented 3 days ago

Codecov Report

Attention: Patch coverage is 43.75000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 62.57%. Comparing base (373ce19) to head (e5f772d).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3569 +/- ## ========================================== + Coverage 62.35% 62.57% +0.22% ========================================== Files 899 898 -1 Lines 69269 69017 -252 Branches 3688 3687 -1 ========================================== - Hits 43191 43188 -3 + Misses 25389 25141 -248 + Partials 689 688 -1 ``` | [Flag](https://app.codecov.io/gh/thirdweb-dev/js/pull/3569/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | Coverage Δ | | *Carryforward flag | |---|---|---|---| | [legacy_packages](https://app.codecov.io/gh/thirdweb-dev/js/pull/3569/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | `65.59% <ø> (ø)` | | Carriedforward from [373ce19](https://app.codecov.io/gh/thirdweb-dev/js/commit/373ce19286b37474112a232690e5c39dc0495988?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | | [packages](https://app.codecov.io/gh/thirdweb-dev/js/pull/3569/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | `62.00% <43.75%> (+0.26%)` | :arrow_up: | | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) to find out more. | [Files](https://app.codecov.io/gh/thirdweb-dev/js/pull/3569?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | Coverage Δ | | |---|---|---| | [packages/thirdweb/src/pay/utils/definitions.ts](https://app.codecov.io/gh/thirdweb-dev/js/pull/3569?src=pr&el=tree&filepath=packages%2Fthirdweb%2Fsrc%2Fpay%2Futils%2Fdefinitions.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev#diff-cGFja2FnZXMvdGhpcmR3ZWIvc3JjL3BheS91dGlscy9kZWZpbml0aW9ucy50cw==) | `87.32% <43.75%> (-1.74%)` | :arrow_down: | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/thirdweb-dev/js/pull/3569/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev)
graphite-app[bot] commented 3 days ago

Merge activity