thirdweb-dev / js

Best in class web3 SDKs for Browser, Node and Mobile apps
https://thirdweb.com
Apache License 2.0
428 stars 324 forks source link

feat(react native): add Skeleton loading state across components #3570

Closed joaquim-verges closed 3 months ago

joaquim-verges commented 3 months ago

PR-Codex overview

This PR introduces theme prop to various components, adds Skeleton loader, and updates ConnectButton and ConnectEmbed components for React Native.

Detailed summary

The following files were skipped due to too many changes: packages/thirdweb/src/react/native/ui/connect/ExternalWalletsList.tsx, packages/thirdweb/src/react/native/ui/connect/ConnectedModal.tsx

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: 1a2e0563299e22dbcac77d177a7b86011ecf377d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------- | ----- | | thirdweb | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2024 4:16am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2024 4:16am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2024 4:16am
graphite-app[bot] commented 3 months ago

Your org requires the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

joaquim-verges commented 3 months ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on Graphite Graphite

github-actions[bot] commented 3 months ago

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 40.48 KB (0%) 810 ms (0%) 3.4 s (-5.62% 🔽) 4.2 s
thirdweb (cjs) 90.48 KB (0%) 1.9 s (0%) 6.8 s (+12.52% 🔺) 8.6 s
thirdweb (minimal + tree-shaking) 4.79 KB (0%) 96 ms (0%) 158 ms (-22.29% 🔽) 254 ms
thirdweb/chains (tree-shaking) 423 B (0%) 10 ms (0%) 71 ms (+36.67% 🔺) 81 ms
thirdweb/react (minimal + tree-shaking) 13.52 KB (0%) 271 ms (0%) 567 ms (+79.68% 🔺) 838 ms
codspeed-hq[bot] commented 3 months ago

CodSpeed Performance Report

Merging #3570 will not alter performance

Comparing feat/add-theme-prop-to-rnimage (1a2e056) with main (0077d38)

Summary

✅ 9 untouched benchmarks

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 62.54%. Comparing base (0077d38) to head (1a2e056).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3570 +/- ## ========================================== - Coverage 62.76% 62.54% -0.23% ========================================== Files 897 898 +1 Lines 68737 69010 +273 Branches 3684 3674 -10 ========================================== + Hits 43145 43160 +15 - Misses 24904 25162 +258 Partials 688 688 ``` | [Flag](https://app.codecov.io/gh/thirdweb-dev/js/pull/3570/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | Coverage Δ | | *Carryforward flag | |---|---|---|---| | [legacy_packages](https://app.codecov.io/gh/thirdweb-dev/js/pull/3570/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | `65.59% <ø> (ø)` | | Carriedforward from [0077d38](https://app.codecov.io/gh/thirdweb-dev/js/commit/0077d38c659391223a0138aca99f15e673eec589?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | | [packages](https://app.codecov.io/gh/thirdweb-dev/js/pull/3570/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | `61.96% <ø> (-0.27%)` | :arrow_down: | | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) to find out more. [see 7 files with indirect coverage changes](https://app.codecov.io/gh/thirdweb-dev/js/pull/3570/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev)
graphite-app[bot] commented 3 months ago

Merge activity