Closed joaquim-verges closed 3 days ago
Latest commit: 95162592451e0b07a69b99bedc28b1c801a66590
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.
You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.
This stack of pull requests is managed by Graphite. Learn more about stacking.
Join @joaquim-verges and the rest of your teammates on Graphite
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
thirdweb_playground | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jul 2, 2024 3:27pm |
thirdweb-www | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jul 2, 2024 3:27pm |
wallet-ui | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jul 2, 2024 3:27pm |
Comparing fix/connect-modal-on-connect-callback
(9516259) with main
(f526d73)
✅ 9
untouched benchmarks
Path | Size | Loading time (3g) | Running time (snapdragon) | Total time |
---|---|---|---|---|
thirdweb (esm) | 40.52 KB (0%) | 811 ms (0%) | 4.7 s (+11.16% 🔺) | 5.5 s |
thirdweb (cjs) | 89.96 KB (0%) | 1.8 s (0%) | 8.6 s (+8.04% 🔺) | 10.4 s |
thirdweb (minimal + tree-shaking) | 4.79 KB (0%) | 96 ms (0%) | 549 ms (+254.03% 🔺) | 645 ms |
thirdweb/chains (tree-shaking) | 423 B (0%) | 10 ms (0%) | 145 ms (-11.61% 🔽) | 155 ms |
thirdweb/react (minimal + tree-shaking) | 13.52 KB (0%) | 271 ms (0%) | 590 ms (+18.52% 🔺) | 860 ms |
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 62.32%. Comparing base (
f526d73
) to head (9516259
).
joaquim-verges
added this pull request to the Graphite merge queue.joaquim-verges
merged this pull request with the Graphite merge queue.
PR-Codex overview
The focus of this PR is to update the
onConnect
function inConnectModal.tsx
to callonClose
before callingonConnect
.Detailed summary
onConnect
function to callonClose
before callingonConnect