thirdweb-dev / js

Best in class web3 SDKs for Browser, Node and Mobile apps
https://thirdweb.com
Apache License 2.0
379 stars 259 forks source link

fix(react-native): ensure onClose is called on successful wallet connection in ConnectModal #3573

Closed joaquim-verges closed 3 days ago

joaquim-verges commented 3 days ago

PR-Codex overview

The focus of this PR is to update the onConnect function in ConnectModal.tsx to call onClose before calling onConnect.

Detailed summary

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

changeset-bot[bot] commented 3 days ago

⚠️ No Changeset found

Latest commit: 95162592451e0b07a69b99bedc28b1c801a66590

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

graphite-app[bot] commented 3 days ago

Your org requires the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

joaquim-verges commented 3 days ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on Graphite Graphite

vercel[bot] commented 3 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2024 3:27pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2024 3:27pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2024 3:27pm
codspeed-hq[bot] commented 3 days ago

CodSpeed Performance Report

Merging #3573 will not alter performance

Comparing fix/connect-modal-on-connect-callback (9516259) with main (f526d73)

Summary

✅ 9 untouched benchmarks

github-actions[bot] commented 3 days ago

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 40.52 KB (0%) 811 ms (0%) 4.7 s (+11.16% 🔺) 5.5 s
thirdweb (cjs) 89.96 KB (0%) 1.8 s (0%) 8.6 s (+8.04% 🔺) 10.4 s
thirdweb (minimal + tree-shaking) 4.79 KB (0%) 96 ms (0%) 549 ms (+254.03% 🔺) 645 ms
thirdweb/chains (tree-shaking) 423 B (0%) 10 ms (0%) 145 ms (-11.61% 🔽) 155 ms
thirdweb/react (minimal + tree-shaking) 13.52 KB (0%) 271 ms (0%) 590 ms (+18.52% 🔺) 860 ms
codecov[bot] commented 3 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 62.32%. Comparing base (f526d73) to head (9516259).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3573 +/- ## ========================================== - Coverage 62.55% 62.32% -0.23% ========================================== Files 898 899 +1 Lines 69011 69270 +259 Branches 3676 3677 +1 ========================================== + Hits 43170 43175 +5 - Misses 25153 25407 +254 Partials 688 688 ``` | [Flag](https://app.codecov.io/gh/thirdweb-dev/js/pull/3573/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | Coverage Δ | | *Carryforward flag | |---|---|---|---| | [legacy_packages](https://app.codecov.io/gh/thirdweb-dev/js/pull/3573/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | `65.59% <ø> (ø)` | | Carriedforward from [f526d73](https://app.codecov.io/gh/thirdweb-dev/js/commit/f526d733d0c512ed607a5fecad8d8e8220f6fe75?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | | [packages](https://app.codecov.io/gh/thirdweb-dev/js/pull/3573/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | `61.71% <ø> (-0.27%)` | :arrow_down: | | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) to find out more. [see 3 files with indirect coverage changes](https://app.codecov.io/gh/thirdweb-dev/js/pull/3573/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev)
graphite-app[bot] commented 3 days ago

Merge activity