search

thirdweb-dev / js

Best in class web3 SDKs for Browser, Node and Mobile apps
https://thirdweb.com
Apache License 2.0
428 stars 324 forks source link

Blockscout v2 contract verification #3576

Closed kumaryash90 closed 3 months ago

kumaryash90 commented 3 months ago

Problem solved

Short description of the bug fixed or feature added

Changes made

How to test

Contributor NFT

Paste in your wallet address below and we will airdrop you a special NFT when your pull request is merged.

Address:

PR-Codex overview

This PR focuses on adding support for Blockscout v2 contract verification.

Detailed summary

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2024 6:29pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2024 6:29pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2024 6:29pm
changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: 687328aae9eb8bb577c000f1183e43dd080ec8f4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------- | ----- | | thirdweb | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 3 months ago

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 40.54 KB (0%) 811 ms (0%) 4.7 s (-2.22% 🔽) 5.5 s
thirdweb (cjs) 90 KB (0%) 1.8 s (0%) 6.5 s (-10.98% 🔽) 8.3 s
thirdweb (minimal + tree-shaking) 4.82 KB (0%) 97 ms (0%) 288 ms (+9.68% 🔺) 384 ms
thirdweb/chains (tree-shaking) 433 B (0%) 10 ms (0%) 56 ms (-38.2% 🔽) 66 ms
thirdweb/react (minimal + tree-shaking) 13.56 KB (0%) 272 ms (0%) 439 ms (+39.33% 🔺) 710 ms
codspeed-hq[bot] commented 3 months ago

CodSpeed Performance Report

Merging #3576 will degrade performances by 12.93%

Comparing yash/blockscoutv2-verification (687328a) with main (0733596)

Summary

❌ 1 regressions ✅ 8 untouched benchmarks

:warning: Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main yash/blockscoutv2-verification Change
❌ keccakId 1.3 ms 1.5 ms -12.93%
codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 62.56%. Comparing base (0733596) to head (687328a).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3576 +/- ## ========================================== + Coverage 62.55% 62.56% +0.01% ========================================== Files 897 897 Lines 69045 69033 -12 Branches 3663 3660 -3 ========================================== Hits 43190 43190 + Misses 25167 25155 -12 Partials 688 688 ``` | [Flag](https://app.codecov.io/gh/thirdweb-dev/js/pull/3576/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | Coverage Δ | | *Carryforward flag | |---|---|---|---| | [legacy_packages](https://app.codecov.io/gh/thirdweb-dev/js/pull/3576/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | `65.66% <ø> (+0.07%)` | :arrow_up: | Carriedforward from [0733596](https://app.codecov.io/gh/thirdweb-dev/js/commit/073359698e37a9a641450265df4f72ee135cf157?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | | [packages](https://app.codecov.io/gh/thirdweb-dev/js/pull/3576/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | `61.98% <ø> (ø)` | | | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) to find out more. | [Files](https://app.codecov.io/gh/thirdweb-dev/js/pull/3576?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | Coverage Δ | | |---|---|---| | [legacy\_packages/sdk/src/evm/common/verification.ts](https://app.codecov.io/gh/thirdweb-dev/js/pull/3576?src=pr&el=tree&filepath=legacy_packages%2Fsdk%2Fsrc%2Fevm%2Fcommon%2Fverification.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev#diff-bGVnYWN5X3BhY2thZ2VzL3Nkay9zcmMvZXZtL2NvbW1vbi92ZXJpZmljYXRpb24udHM=) | `13.04% <ø> (+0.84%)` | :arrow_up: | | [...ages/sdk/src/evm/core/classes/contract-verifier.ts](https://app.codecov.io/gh/thirdweb-dev/js/pull/3576?src=pr&el=tree&filepath=legacy_packages%2Fsdk%2Fsrc%2Fevm%2Fcore%2Fclasses%2Fcontract-verifier.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev#diff-bGVnYWN5X3BhY2thZ2VzL3Nkay9zcmMvZXZtL2NvcmUvY2xhc3Nlcy9jb250cmFjdC12ZXJpZmllci50cw==) | `36.36% <ø> (+5.59%)` | :arrow_up: |
graphite-app[bot] commented 3 months ago

Merge activity