thirdweb-dev / js

Best in class web3 SDKs for Browser, Node and Mobile apps
https://thirdweb.com
Apache License 2.0
379 stars 259 forks source link

feature(react): show ecosystem wallet branding regardless of modal size #3577

Closed gregfromstl closed 3 days ago

gregfromstl commented 3 days ago

PR-Codex overview

This PR focuses on showing ecosystem wallet branding on a wide modal layout.

Detailed summary

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

vercel[bot] commented 3 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2024 9:02pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2024 9:02pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2024 9:02pm
changeset-bot[bot] commented 3 days ago

🦋 Changeset detected

Latest commit: 6b919e13859e146f572619bfb315d5c357808a0e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------- | ----- | | thirdweb | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

gregfromstl commented 3 days ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @gregfromstl and the rest of your teammates on Graphite Graphite

graphite-app[bot] commented 3 days ago

Your org requires the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

codspeed-hq[bot] commented 3 days ago

CodSpeed Performance Report

Merging #3577 will not alter performance

Comparing feature/ecosystem-wide-branding (6b919e1) with main (2b5ee62)

Summary

✅ 9 untouched benchmarks

github-actions[bot] commented 3 days ago

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 40.52 KB (0%) 811 ms (0%) 3.1 s (+31.85% 🔺) 3.9 s
thirdweb (cjs) 89.96 KB (0%) 1.8 s (0%) 6.6 s (+24.51% 🔺) 8.4 s
thirdweb (minimal + tree-shaking) 4.79 KB (0%) 96 ms (0%) 423 ms (+130.29% 🔺) 519 ms
thirdweb/chains (tree-shaking) 423 B (0%) 10 ms (0%) 64 ms (+36.41% 🔺) 74 ms
thirdweb/react (minimal + tree-shaking) 13.52 KB (0%) 271 ms (0%) 423 ms (-31.45% 🔽) 693 ms
codecov[bot] commented 3 days ago

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 62.77%. Comparing base (2b5ee62) to head (6b919e1).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3577 +/- ## ========================================== + Coverage 62.74% 62.77% +0.03% ========================================== Files 897 897 Lines 68739 68735 -4 Branches 3677 3687 +10 ========================================== + Hits 43132 43151 +19 + Misses 24919 24895 -24 - Partials 688 689 +1 ``` | [Flag](https://app.codecov.io/gh/thirdweb-dev/js/pull/3577/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | Coverage Δ | | *Carryforward flag | |---|---|---|---| | [legacy_packages](https://app.codecov.io/gh/thirdweb-dev/js/pull/3577/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | `65.59% <ø> (ø)` | | Carriedforward from [2b5ee62](https://app.codecov.io/gh/thirdweb-dev/js/commit/2b5ee62b2b21e9a7a91e1e1afdd88ef061810ee8?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | | [packages](https://app.codecov.io/gh/thirdweb-dev/js/pull/3577/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | `62.24% <0.00%> (+0.03%)` | :arrow_up: | | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) to find out more. | [Files](https://app.codecov.io/gh/thirdweb-dev/js/pull/3577?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | Coverage Δ | | |---|---|---| | [...ct/web/wallets/ecosystem/EcosystemWalletFormUI.tsx](https://app.codecov.io/gh/thirdweb-dev/js/pull/3577?src=pr&el=tree&filepath=packages%2Fthirdweb%2Fsrc%2Freact%2Fweb%2Fwallets%2Fecosystem%2FEcosystemWalletFormUI.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev#diff-cGFja2FnZXMvdGhpcmR3ZWIvc3JjL3JlYWN0L3dlYi93YWxsZXRzL2Vjb3N5c3RlbS9FY29zeXN0ZW1XYWxsZXRGb3JtVUkudHN4) | `42.69% <0.00%> (+1.83%)` | :arrow_up: | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/thirdweb-dev/js/pull/3577/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev)
graphite-app[bot] commented 3 days ago

Merge activity