Closed jnsdls closed 3 days ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
thirdweb_playground | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jul 2, 2024 9:53pm |
thirdweb-www | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jul 2, 2024 9:53pm |
wallet-ui | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jul 2, 2024 9:53pm |
Latest commit: f5b8afef5ce7294073e333a4dda21d70e0f1ddf2
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.
You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.
This stack of pull requests is managed by Graphite. Learn more about stacking.
Join @jnsdls and the rest of your teammates on Graphite
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 62.75%. Comparing base (
4786c2d
) to head (f5b8afe
).
Comparing fix/chain-icon-bug
(f5b8afe) with main
(4786c2d)
✅ 9
untouched benchmarks
Path | Size | Loading time (3g) | Running time (snapdragon) | Total time |
---|---|---|---|---|
thirdweb (esm) | 40.52 KB (0%) | 811 ms (0%) | 510 ms (+70.11% 🔺) | 1.4 s |
thirdweb (cjs) | 89.96 KB (0%) | 1.8 s (0%) | 837 ms (+11.21% 🔺) | 2.7 s |
thirdweb (minimal + tree-shaking) | 4.79 KB (0%) | 96 ms (0%) | 21 ms (-45.32% 🔽) | 117 ms |
thirdweb/chains (tree-shaking) | 423 B (0%) | 10 ms (0%) | 11 ms (+39.8% 🔺) | 21 ms |
thirdweb/react (minimal + tree-shaking) | 13.52 KB (0%) | 271 ms (0%) | 46 ms (-33.09% 🔽) | 317 ms |
jnsdls
added this pull request to the Graphite merge queue.jnsdls
merged this pull request with the Graphite merge queue.
no longer needed
PR-Codex overview
This PR updates the
chain-icon.tsx
file in the dashboard app to fix a bug related to theiconUrl
by removing a specific string.Detailed summary
iconUrl
by removing "ipfs://" string