thirdweb-dev / js

Best in class web3 SDKs for Browser, Node and Mobile apps
https://thirdweb.com
Apache License 2.0
379 stars 259 forks source link

[Fix] Remove IPFS replacement hack in ChainIcon component #3579

Closed jnsdls closed 3 days ago

jnsdls commented 3 days ago

no longer needed


PR-Codex overview

This PR updates the chain-icon.tsx file in the dashboard app to fix a bug related to the iconUrl by removing a specific string.

Detailed summary

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

vercel[bot] commented 3 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2024 9:53pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2024 9:53pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 2, 2024 9:53pm
changeset-bot[bot] commented 3 days ago

⚠️ No Changeset found

Latest commit: f5b8afef5ce7294073e333a4dda21d70e0f1ddf2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

graphite-app[bot] commented 3 days ago

Your org requires the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

jnsdls commented 3 days ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jnsdls and the rest of your teammates on Graphite Graphite

codecov[bot] commented 3 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 62.75%. Comparing base (4786c2d) to head (f5b8afe).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3579 +/- ## ======================================= Coverage 62.75% 62.75% ======================================= Files 897 897 Lines 68735 68735 Branches 3675 3675 ======================================= Hits 43132 43132 Misses 24915 24915 Partials 688 688 ``` | [Flag](https://app.codecov.io/gh/thirdweb-dev/js/pull/3579/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | Coverage Δ | | *Carryforward flag | |---|---|---|---| | [legacy_packages](https://app.codecov.io/gh/thirdweb-dev/js/pull/3579/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | `65.59% <ø> (ø)` | | Carriedforward from [4786c2d](https://app.codecov.io/gh/thirdweb-dev/js/commit/4786c2da72346d6cb2f18e3c3f9ac2989238388e?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | | [packages](https://app.codecov.io/gh/thirdweb-dev/js/pull/3579/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | `62.21% <ø> (ø)` | | | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) to find out more.
codspeed-hq[bot] commented 3 days ago

CodSpeed Performance Report

Merging #3579 will not alter performance

Comparing fix/chain-icon-bug (f5b8afe) with main (4786c2d)

Summary

✅ 9 untouched benchmarks

github-actions[bot] commented 3 days ago

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 40.52 KB (0%) 811 ms (0%) 510 ms (+70.11% 🔺) 1.4 s
thirdweb (cjs) 89.96 KB (0%) 1.8 s (0%) 837 ms (+11.21% 🔺) 2.7 s
thirdweb (minimal + tree-shaking) 4.79 KB (0%) 96 ms (0%) 21 ms (-45.32% 🔽) 117 ms
thirdweb/chains (tree-shaking) 423 B (0%) 10 ms (0%) 11 ms (+39.8% 🔺) 21 ms
thirdweb/react (minimal + tree-shaking) 13.52 KB (0%) 271 ms (0%) 46 ms (-33.09% 🔽) 317 ms
graphite-app[bot] commented 3 days ago

Merge activity