[Feature] Add Engine Account support

jnsdls commented 2 days ago

PR-Codex overview

The focus of this PR is to export EngineAccountOptions and engineAccount from engine-account.js.

Detailed summary

Export EngineAccountOptions and engineAccount from engine-account.js
Add engineAccount function to create engine accounts with specified options
Implement methods for sending transactions, signing messages, and signing typed data
Handle engine requests for transactions, messages, and typed data signing

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

vercel[bot] commented 2 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
thirdweb_playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 3, 2024 6:08pm
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 3, 2024 6:08pm
wallet-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 3, 2024 6:08pm

changeset-bot[bot] commented 2 days ago

⚠️ No Changeset found

Latest commit: 12286c3c44b0bef7d3c6f1866613ed5c9354c12b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

graphite-app[bot] commented 2 days ago

Your org requires the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

jnsdls commented 2 days ago

#3584 👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jnsdls and the rest of your teammates on Graphite

jnsdls commented 2 days ago

TODO: add tests

codspeed-hq[bot] commented 2 days ago

CodSpeed Performance Report

Merging #3584 will not alter performance

_{Comparing feature/add-engine-account (12286c3) with main (0733596)}

Summary

✅ 9 untouched benchmarks

github-actions[bot] commented 2 days ago

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	40.54 KB (0%)	811 ms (0%)	2.9 s (+15.17% 🔺)	3.7 s
thirdweb (cjs)	90 KB (0%)	1.8 s (0%)	7.3 s (+16.77% 🔺)	9.1 s
thirdweb (minimal + tree-shaking)	4.82 KB (0%)	97 ms (0%)	144 ms (-60.77% 🔽)	240 ms
thirdweb/chains (tree-shaking)	433 B (0%)	10 ms (0%)	105 ms (+17.37% 🔺)	115 ms
thirdweb/react (minimal + tree-shaking)	13.56 KB (0%)	272 ms (0%)	452 ms (+27.06% 🔺)	723 ms

codecov[bot] commented 2 days ago

Codecov Report

Attention: Patch coverage is 19.10112% with 144 lines in your changes missing coverage. Please review.

Project coverage is 62.64%. Comparing base (0733596) to head (12286c3).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #3584 +/- ## ========================================== + Coverage 62.55% 62.64% +0.08% ========================================== Files 897 897 Lines 69045 68950 -95 Branches 3663 3662 -1 ========================================== + Hits 43190 43192 +2 + Misses 25167 25070 -97 Partials 688 688 ``` | [Flag](https://app.codecov.io/gh/thirdweb-dev/js/pull/3584/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | Coverage Δ | | *Carryforward flag | |---|---|---|---| | [legacy_packages](https://app.codecov.io/gh/thirdweb-dev/js/pull/3584/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | `65.59% <ø> (ø)` | | Carriedforward from [0733596](https://app.codecov.io/gh/thirdweb-dev/js/commit/073359698e37a9a641450265df4f72ee135cf157?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | | [packages](https://app.codecov.io/gh/thirdweb-dev/js/pull/3584/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | `62.08% <19.10%> (+0.10%)` | :arrow_up: | | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) to find out more. | [Files](https://app.codecov.io/gh/thirdweb-dev/js/pull/3584?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | Coverage Δ | | |---|---|---| | [packages/thirdweb/src/wallets/engine-account.ts](https://app.codecov.io/gh/thirdweb-dev/js/pull/3584?src=pr&el=tree&filepath=packages%2Fthirdweb%2Fsrc%2Fwallets%2Fengine-account.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev#diff-cGFja2FnZXMvdGhpcmR3ZWIvc3JjL3dhbGxldHMvZW5naW5lLWFjY291bnQudHM=) | `19.10% <19.10%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/thirdweb-dev/js/pull/3584/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev)

thirdweb-dev / js