simplify siwe auth login flow

jnsdls commented 1 month ago

PR-Codex overview

This PR focuses on updating the doLogin function in auth-actions.ts to enhance user account handling by automatically creating an account if it does not exist during the login process.

Detailed summary

Added createAccount: true to the payload when calling the login API.
Implemented error handling to clear cookies if the login request fails.
Removed the previous user existence check and account creation logic after login.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 26, 2024 1:32am

3 Skipped Deployments

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: 9c58c08945975ed8c5b36dea25dd74e3a6a8f8d2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

graphite-app[bot] commented 1 month ago

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

jnsdls commented 1 month ago

#4808 👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jnsdls and the rest of your teammates on Graphite

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 49.14%. Comparing base (587804d) to head (9c58c08). Report is 1 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #4808 +/- ## ======================================= Coverage 49.14% 49.14% ======================================= Files 1051 1051 Lines 56711 56711 Branches 3889 3889 ======================================= Hits 27869 27869 Misses 28209 28209 Partials 633 633 ``` | [Flag](https://app.codecov.io/gh/thirdweb-dev/js/pull/4808/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | Coverage Δ | | *Carryforward flag | |---|---|---|---| | [legacy_packages](https://app.codecov.io/gh/thirdweb-dev/js/pull/4808/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | `65.68% <ø> (ø)` | | Carriedforward from [587804d](https://app.codecov.io/gh/thirdweb-dev/js/commit/587804d5a8454441ce03c7568ca372548a2d137b?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | | [packages](https://app.codecov.io/gh/thirdweb-dev/js/pull/4808/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | `45.21% <ø> (ø)` | | | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) to find out more.

github-actions[bot] commented 1 month ago

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	41.93 KB (0%)	839 ms (0%)	500 ms (+127.05% 🔺)	1.4 s
thirdweb (cjs)	101.55 KB (0%)	2.1 s (0%)	706 ms (+15.37% 🔺)	2.8 s
thirdweb (minimal + tree-shaking)	4.82 KB (0%)	97 ms (0%)	20 ms (-43.63% 🔽)	117 ms
thirdweb/chains (tree-shaking)	498 B (0%)	10 ms (0%)	9 ms (+58.66% 🔺)	19 ms
thirdweb/react (minimal + tree-shaking)	16.78 KB (0%)	336 ms (0%)	87 ms (+9.6% 🔺)	423 ms

graphite-app[bot] commented 1 month ago

Merge activity

Sep 25, 9:22 PM EDT: jnsdls added this pull request to the Graphite merge queue.
Sep 25, 9:32 PM EDT: jnsdls merged this pull request with the Graphite merge queue.

thirdweb-dev / js