search

thirdweb-dev / js

Best in class web3 SDKs for Browser, Node and Mobile apps
https://thirdweb.com
Apache License 2.0
428 stars 324 forks source link

[SDK] Fix: logout on iframe #4809

Closed gregfromstl closed 1 week ago

gregfromstl commented 1 week ago

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR focuses on fixing issues related to account logout state and updating error handling for transaction claims across multiple test files in the thirdweb package.

Detailed summary

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

changeset-bot[bot] commented 1 week ago

🦋 Changeset detected

Latest commit: 500970e001e60be21b00e6f5cb5b1f170165f274

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------- | ----- | | thirdweb | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 2:23am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 2:23am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 2:23am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 2:23am
graphite-app[bot] commented 1 week ago

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

github-actions[bot] commented 1 week ago

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 41.93 KB (0%) 839 ms (0%) 2.5 s (+1.21% 🔺) 3.4 s
thirdweb (cjs) 101.55 KB (0%) 2.1 s (0%) 5.3 s (-0.27% 🔽) 7.3 s
thirdweb (minimal + tree-shaking) 4.82 KB (0%) 97 ms (0%) 242 ms (+70.29% 🔺) 338 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 99 ms (+12.35% 🔺) 109 ms
thirdweb/react (minimal + tree-shaking) 16.78 KB (0%) 336 ms (0%) 651 ms (+52.02% 🔺) 987 ms
codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 49.14%. Comparing base (9c58c08) to head (500970e). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...hirdweb/src/react/web/ui/ConnectWallet/Details.tsx 0.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4809 +/- ## ======================================= Coverage 49.14% 49.14% ======================================= Files 1051 1051 Lines 56711 56714 +3 Branches 3889 3893 +4 ======================================= + Hits 27869 27872 +3 Misses 28209 28209 Partials 633 633 ``` | [Flag](https://app.codecov.io/gh/thirdweb-dev/js/pull/4809/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | Coverage Δ | | *Carryforward flag | |---|---|---|---| | [legacy_packages](https://app.codecov.io/gh/thirdweb-dev/js/pull/4809/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | `65.68% <ø> (ø)` | | Carriedforward from [9c58c08](https://app.codecov.io/gh/thirdweb-dev/js/commit/9c58c08945975ed8c5b36dea25dd74e3a6a8f8d2?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | | [packages](https://app.codecov.io/gh/thirdweb-dev/js/pull/4809/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | `45.21% <0.00%> (+<0.01%)` | :arrow_up: | | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) to find out more. | [Files with missing lines](https://app.codecov.io/gh/thirdweb-dev/js/pull/4809?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | Coverage Δ | | |---|---|---| | [...hirdweb/src/react/web/ui/ConnectWallet/Details.tsx](https://app.codecov.io/gh/thirdweb-dev/js/pull/4809?src=pr&el=tree&filepath=packages%2Fthirdweb%2Fsrc%2Freact%2Fweb%2Fui%2FConnectWallet%2FDetails.tsx&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev#diff-cGFja2FnZXMvdGhpcmR3ZWIvc3JjL3JlYWN0L3dlYi91aS9Db25uZWN0V2FsbGV0L0RldGFpbHMudHN4) | `7.28% <0.00%> (-0.03%)` | :arrow_down: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/thirdweb-dev/js/pull/4809/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev)
graphite-app[bot] commented 1 week ago

Merge activity