thirdweb-dev / js

Best in class web3 SDKs for Browser, Node and Mobile apps
https://thirdweb.com
Apache License 2.0
428 stars 324 forks source link

[Dashboard] Remove non-branding icons #4810

Closed kien-ngo closed 6 days ago

kien-ngo commented 6 days ago

PR-Codex overview

This PR primarily focuses on replacing icons from the @react-icons/all-files library with equivalent icons from the lucide-react library across various components, enhancing consistency and potentially improving performance.

Detailed summary

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

changeset-bot[bot] commented 6 days ago

⚠️ No Changeset found

Latest commit: ebd5908d4ad95438c2646c554d0b73e0d9d6f608

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 6 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 1:21am
3 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **docs-v2** | ⬜️ Skipped ([Inspect](https://vercel.com/thirdweb/docs-v2/8tmzRiDVR9xkfzdkJSRpMyKeRRfr)) | | | Sep 27, 2024 1:21am | | **thirdweb_playground** | ⬜️ Skipped ([Inspect](https://vercel.com/thirdweb/thirdweb_playground/ExYhfZBSYqsKA36V6bkehq4MZ8SA)) | | | Sep 27, 2024 1:21am | | **wallet-ui** | ⬜️ Skipped ([Inspect](https://vercel.com/thirdweb/wallet-ui/GBgvf7NFzw1uVeZAUZCqct5gCGge)) | | | Sep 27, 2024 1:21am |
graphite-app[bot] commented 6 days ago

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

codecov[bot] commented 6 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 47.67%. Comparing base (21b032d) to head (ebd5908). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4810 +/- ## ======================================= Coverage 47.67% 47.67% ======================================= Files 1051 1051 Lines 56715 56715 Branches 3894 3894 ======================================= Hits 27040 27040 Misses 28988 28988 Partials 687 687 ``` | [Flag](https://app.codecov.io/gh/thirdweb-dev/js/pull/4810/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | Coverage Δ | | *Carryforward flag | |---|---|---|---| | [legacy_packages](https://app.codecov.io/gh/thirdweb-dev/js/pull/4810/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | `65.68% <ø> (ø)` | | Carriedforward from [21b032d](https://app.codecov.io/gh/thirdweb-dev/js/commit/21b032d1b845276817c2f8ada5566f4719a41ad0?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | | [packages](https://app.codecov.io/gh/thirdweb-dev/js/pull/4810/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | `43.40% <ø> (ø)` | | | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) to find out more.
github-actions[bot] commented 6 days ago

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 41.93 KB (0%) 839 ms (0%) 3.8 s (+55.02% 🔺) 4.6 s
thirdweb (cjs) 101.55 KB (0%) 2.1 s (0%) 7.1 s (-1.25% 🔽) 9.1 s
thirdweb (minimal + tree-shaking) 4.82 KB (0%) 97 ms (0%) 238 ms (-22.97% 🔽) 334 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 365 ms (+599.07% 🔺) 375 ms
thirdweb/react (minimal + tree-shaking) 16.78 KB (0%) 336 ms (0%) 968 ms (-0.73% 🔽) 1.4 s
kien-ngo commented 6 days ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @kien-ngo and the rest of your teammates on Graphite Graphite

graphite-app[bot] commented 6 days ago

Merge activity