Closed kien-ngo closed 6 days ago
Latest commit: ebd5908d4ad95438c2646c554d0b73e0d9d6f608
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
thirdweb-www | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Sep 27, 2024 1:21am |
Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.
You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 47.67%. Comparing base (
21b032d
) to head (ebd5908
). Report is 1 commits behind head on main.
Path | Size | Loading time (3g) | Running time (snapdragon) | Total time |
---|---|---|---|---|
thirdweb (esm) | 41.93 KB (0%) | 839 ms (0%) | 3.8 s (+55.02% 🔺) | 4.6 s |
thirdweb (cjs) | 101.55 KB (0%) | 2.1 s (0%) | 7.1 s (-1.25% 🔽) | 9.1 s |
thirdweb (minimal + tree-shaking) | 4.82 KB (0%) | 97 ms (0%) | 238 ms (-22.97% 🔽) | 334 ms |
thirdweb/chains (tree-shaking) | 498 B (0%) | 10 ms (0%) | 365 ms (+599.07% 🔺) | 375 ms |
thirdweb/react (minimal + tree-shaking) | 16.78 KB (0%) | 336 ms (0%) | 968 ms (-0.73% 🔽) | 1.4 s |
This stack of pull requests is managed by Graphite. Learn more about stacking.
Join @kien-ngo and the rest of your teammates on Graphite
MananTank
added this pull request to the Graphite merge queue.MananTank
merged this pull request with the Graphite merge queue.
PR-Codex overview
This PR primarily focuses on replacing icons from the
@react-icons/all-files
library with equivalent icons from thelucide-react
library across various components, enhancing consistency and potentially improving performance.Detailed summary
IconType
prop from several interfaces.@react-icons/all-files
icons withlucide-react
icons in components likeHackathonFooter
,NFTClaimButton
,SelectOption
, and others.MobileNavSection
andNavCard
.