[SDK] Fix: Ensure optional chains included

gregfromstl commented 5 days ago

PR-Codex overview

This PR focuses on enhancing the useCreateEcosystem functionality by adding support for authentication options. It updates various components to handle these options, ensuring that they can be created and managed effectively within the ecosystem.

Detailed summary

Added authOptions to the useCreateEcosystem hook.
Updated the auth-options-form.client.tsx to check for authOptions safely.
Modified getChainsToRequest to include requiredChain and optionalChains.
Enhanced CreateEcosystemForm to include authOptions in the form schema and default values.
Implemented a checkbox selection for authentication options in CreateEcosystemForm.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

changeset-bot[bot] commented 5 days ago

⚠️ No Changeset found

Latest commit: b6eaac80f227d0c11bb9cf7dd7b68561c05c1d10

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 5 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-v2	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Sep 28, 2024 2:03am
thirdweb_playground	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Sep 28, 2024 2:03am
thirdweb-www	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Sep 28, 2024 2:03am
wallet-ui	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Sep 28, 2024 2:03am

graphite-app[bot] commented 5 days ago

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

github-actions[bot] commented 5 days ago

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	41.94 KB (0%)	839 ms (0%)	383 ms (+42.82% 🔺)	1.3 s
thirdweb (cjs)	101.6 KB (0%)	2.1 s (0%)	478 ms (-15.53% 🔽)	2.6 s
thirdweb (minimal + tree-shaking)	4.82 KB (0%)	97 ms (0%)	47 ms (+47.79% 🔺)	143 ms
thirdweb/chains (tree-shaking)	498 B (0%)	10 ms (0%)	10 ms (+21.14% 🔺)	20 ms
thirdweb/react (minimal + tree-shaking)	16.78 KB (0%)	336 ms (0%)	43 ms (+11.32% 🔺)	378 ms

codecov[bot] commented 5 days ago

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 47.73%. Comparing base (601958d) to head (b6eaac8).

Files with missing lines	Patch %	Lines
.../thirdweb/src/wallets/wallet-connect/controller.ts	0.00%	19 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #4837 +/- ## ========================================== - Coverage 47.73% 47.73% -0.01% ========================================== Files 1051 1051 Lines 56707 56716 +9 Branches 3903 3904 +1 ========================================== + Hits 27068 27071 +3 - Misses 28951 28957 +6 Partials 688 688 ``` | [Flag](https://app.codecov.io/gh/thirdweb-dev/js/pull/4837/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | Coverage Δ | | *Carryforward flag | |---|---|---|---| | [legacy_packages](https://app.codecov.io/gh/thirdweb-dev/js/pull/4837/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | `65.68% <ø> (ø)` | | Carriedforward from [601958d](https://app.codecov.io/gh/thirdweb-dev/js/commit/601958d5b77238885335bf865ea282eb27fb8794?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | | [packages](https://app.codecov.io/gh/thirdweb-dev/js/pull/4837/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | `43.46% <0.00%> (-0.01%)` | :arrow_down: | | *This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) to find out more. | [Files with missing lines](https://app.codecov.io/gh/thirdweb-dev/js/pull/4837?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev) | Coverage Δ | | |---|---|---| | [.../thirdweb/src/wallets/wallet-connect/controller.ts](https://app.codecov.io/gh/thirdweb-dev/js/pull/4837?src=pr&el=tree&filepath=packages%2Fthirdweb%2Fsrc%2Fwallets%2Fwallet-connect%2Fcontroller.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev#diff-cGFja2FnZXMvdGhpcmR3ZWIvc3JjL3dhbGxldHMvd2FsbGV0LWNvbm5lY3QvY29udHJvbGxlci50cw==) | `9.44% <0.00%> (-0.21%)` | :arrow_down: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/thirdweb-dev/js/pull/4837/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=thirdweb-dev)

thirdweb-dev / js