search

thirdweb-dev / react

Ultimate collection of React hooks for your web3 apps
https://docs.thirdweb.com/react
Apache License 2.0
80 stars 29 forks source link

coinbase cookies #64

Closed 7flash closed 2 years ago

7flash commented 2 years ago

when I try to authorize with metamask.. its writing some values to my local storage.. not sure what's the purpose.. even though I didn't include coinbase wallet option..

image

nachoiacovino commented 2 years ago

Hello @7flash , do you have Coinbase Wallet also installed in your browser?

7flash commented 2 years ago

Hello @7flash , do you have Coinbase Wallet also installed in your browser?

nope

nachoiacovino commented 2 years ago

Okay thank you for the info, we default to enabling CB Wallet, WalletConnect and MetaMask to have them ready to go. cc @jnsdls for confirmation.

On our next react version, we will make it so you pass which wallets you want to support (with the addition to supporting more wallets, so this issue should be fixed then, we're. working on this.

Sorry for the trouble in the meantime.

jnsdls commented 2 years ago

Yep, these local storage values are being written by the coinbase-wallet SDK. Nacho covered it pretty closely.

We'll add more granular control of which exact wallets you would like to support in your dApp in the next upgrade of the react sdk which should ship within the next 1-2 weeks.

I'm closing this for now but will reference it back when that update ships. Thanks again for bringing this up @7flash! :)