search

thirdy / durian

Path of Exile Items watcher
http://thirdy.github.io/durian/
GNU General Public License v2.0
35 stars 10 forks source link

Added attack speed mod search #29

Closed Haroldyolo closed 8 years ago

Haroldyolo commented 8 years ago

Please check if its done properly Thirdy I am new to this.

thirdy commented 8 years ago

Nice work. You'll need to make a few corrections:

(\d+) (atkspeed|attackspeed )
(\d+)-(\d+) (atkspeed|attackspeed )

There are extra spaces, so it should be like this:

(\d+)(atkspeed|attackspeed)
(\d+)-(\d+)(atkspeed|attackspeed)

There is an existing aps search term (defined in terms/attributes.txt) which is for the final APS. It might be a good idea to name the mods as %aps or %atkspeed to make it clear that it's for the aps modifier. - not sure -

thirdy commented 8 years ago

as per this post, ias is better to use for this:

https://www.pathofexile.com/forum/view-thread/1507190/page/9#p12418093