search

thirtybees / beesblog

Blog module for thirty bees
Academic Free License v3.0
1 stars 12 forks source link

Added support for updateFriendlyURL() #39

Closed yaniv14 closed 5 years ago

yaniv14 commented 5 years ago

Right now admin.js throw an error when entering Blog post title due to missing PS_ALLOW_ACCENTED_CHARS_URL variable.

Blog category name not even trying to populate URL rewrite.

getdatakick commented 5 years ago

Thank you for the contribution. I have picked modified version of your fix to the codebase - see commit 6022b479caafbad1f06b0c63cc7d5d20e72ec20a

yaniv14 commented 5 years ago

@getdatakick Are you sure that all changes were merged? I dont see the tpl files in the master repo.

getdatakick commented 5 years ago

I didn't merge your pull request, I used it as a basis for different fix.

The reason why you added helper overrides was to inject javascript variable into the page. There's a better way to do that - use Media::addJsDef method

yaniv14 commented 5 years ago

Perfect. There should be other places where you can use that approach, because originally I took that part of the code from other templates i found.