search

thirtybees / coreupdater

thirty bees module for updating thirty bees core.
Academic Free License v3.0
0 stars 5 forks source link

Remove extra slash #2

Closed yaniv14 closed 5 years ago

yaniv14 commented 5 years ago

_PS_CACHEDIR ends with forward slash

Traumflug commented 5 years ago

Is there some other reason than just prettiness?

Such a change breaks code if these constants don't add the slash, like all the PHP libraries do. That's why I intentionally added them.

yaniv14 commented 5 years ago

I can't tell because I didn't have any issues with this. It just make sense because PS_CACHE_DIR returns '.... /cache/' on my previous PR https://github.com/thirtybees/coreupdater/pull/1 i encounter an error, so I figured it could be the same case here.

Traumflug commented 5 years ago

Picked as part of 64f93fa8f1f21e4a0672381e793b1b45b41f42fd. Thank you very much for the contribution!