search

thirtybees / homeslider

Academic Free License v3.0
0 stars 2 forks source link

Images are lost after update #3

Closed eschiendorfer closed 1 year ago

eschiendorfer commented 6 years ago

I have updated this module now twice this week. In both cases my slider images were gone. They don't show up in backoffice and also not in front office.

It could be related to multistore!? TB Version is 1.0.3.

For the themconfigurator I noted the same problem...

Dh42 commented 6 years ago

It seems to happen on the standard non multi-store as well. I just got a report about it in my support queue.

Traumflug commented 6 years ago

It smells a bit like an somehow changed update process. Code changes of the last two releases are limited to pretty much comment and whitespace edits. Now I wonder why these images did not go with earlier releases.

eschiendorfer commented 6 years ago

I believe, they did get lost already before. When I migrated, I had the same issue. Back then, I thought it was because of the migration process... Now I know it better ofc.

selwynorren commented 6 years ago

Same thing happened to me. I logged into my admin interface and had a whole bunch of modules that needed updating. I updated them all and all my images for these module have all been deleted from the server. This specific homeslider module no all of a sudden has css not in another location where it never was before, which means my theme is not applying the styles at all

Traumflug commented 6 years ago

This specific homeslider module no all of a sudden has css not in another location where it never was before, which means my theme is not applying the styles at all

Obviously a result of the new packaging script, which no longer forgets one file or another.

CSS files in the theme override those in the module, so creating an empty file themes/<theme>/css/modules/homeslider/<file>.css should solve the issue (and won't get overwritten with the next module upgrade either).

Dh42 commented 5 years ago

I tested this, the only thing I can come up with is a permissions issue on the /images directory that caused the issue. I added a build script and tested an upgrade from the current version to the new version and did not have the issue. I am closing this for now and making a new release.

eschiendorfer commented 5 years ago

I am not sure, if it's good to close this one. I just updated theme configurator from 3.0.6. to 3.0.7 and lost again the images. I believe there is some issue left...

Traumflug commented 5 years ago

Proposed solution: don't store these images in the module folder. Images go to img/. Those in the module folder are only templates and should get copied to img/homeslider/ on installation. Front end HTML should expect them there.

Reason: when updater updates a module, it removes the entire directory, then unpacks the new release. Accordingly, all files inside the module folder are gone.

selwynorren commented 5 years ago

Proposed solution: don't store these images in the module folder. Images go to img/. Those in the module folder are only templates and should get copied to img/homeslider/ on installation. Front end HTML should expect them there.

Reason: when updater updates a module, it removes the entire directory, then unpacks the new release. Accordingly, all files inside the module folder are gone.

This would be an awesome solution, It gets pretty irritating when each time an update runs, then we have to re-upload the images again, Love this way of handling the images

selwynorren commented 1 year ago

Just a heads up to anyone. With the new changes, it never backups or transferred my images to the new location and I lost everything again... Fortunately I still have my backups