Tabs on the front page don't work right

thirtybees / niara

Niara, thirty bees default theme since v1.1.0.

https://thirtybees.com

9 stars 25 forks source link

Tabs on the front page don't work right #2

Closed Traumflug closed 5 years ago

Traumflug commented 5 years ago

There are three tabs, New arrivals, Popular and Best sellers.

Clicking on Popular apparently does nothing.
Clicking on Best sellers removes the part above Our featured products and appends best sellers below this section, without heading. Which then looks like no best sellers, but twice as many featured products.

Dh42 commented 5 years ago

These two commits should fix the home featured part

https://github.com/thirtybees/homefeatured/commit/ccd73c36f2cc38e2f28333fbf83f65b47c9e2aeb

https://github.com/thirtybees/niara/commit/f3d94ae3c4df325511819c207336b9a481396d68

For the best sellers I think we need to populate information to the database.

Dh42 commented 5 years ago

Actually it looks like fixing that template also fixed the best sellers too, I call that a win.

Dh42 commented 5 years ago

They should be working now. I am going to close this, I am going to commit using rows instead of tabs on the home page as well. Just to keep it cleaner and more modern.