search

thirtybees / niara

Niara, thirty bees default theme since v1.1.0.
https://thirtybees.com
9 stars 26 forks source link

Replace jscs with eslint #28

Closed kristho91 closed 4 years ago

kristho91 commented 4 years ago

This is first draft for bug #25

Everything work as intended. JSCS is gone and Eslint is in. There was an old .eslintrc , which is removed and replaced with a new .eslintrc.js (the .eslintrc file is deprecated). I did not copy the old rules, as they have never been in use, and I wanted a simpler config file - please let me know if there is any recommended settings this project want to use.

When running "npm run format-js" it will now output all issues in the JS files (which is 753 with this config). The old JSCS did not output issues - in fact, I'm not sure it did anything.

getdatakick commented 4 years ago

Awesome job, this is a great jump ahead. Now we only have to fix those 753 errors warnings / errors.

I've rebased and integrated your changes directly from you fork.