As I see the "format-js" Gulp-step, it's not as much a build step, as it is a lint-step.
1) The documentation (README) says that it is needed to run "npm run format-js" for building JS, I do not think this is necessary.
2) All files that is processed in the "format-js"-step is "copied" to the "js"-folder, this is not necessary as no changes to the files are made (nothing is actually being "built" - just linted).
3) The gulpfile.js is one of the files that goes through the "format-js"-step. And this is the only file that is actually copied to "js"-folder - where it does not belong, and this is fixed by a "hack" in .gitignore.
2 & 3 could be fixed by seeing this step as a linting step and not a necessary build-step, and NOT copy the files to "js"-folder where they already are.
kristho91
commented
4 years ago
As I see the "format-js" Gulp-step, it's not as much a build step, as it is a lint-step.
1) The documentation (README) says that it is needed to run "npm run format-js" for building JS, I do not think this is necessary.
2) All files that is processed in the "format-js"-step is "copied" to the "js"-folder, this is not necessary as no changes to the files are made (nothing is actually being "built" - just linted).
3) The gulpfile.js is one of the files that goes through the "format-js"-step. And this is the only file that is actually copied to "js"-folder - where it does not belong, and this is fixed by a "hack" in .gitignore.
2 & 3 could be fixed by seeing this step as a linting step and not a necessary build-step, and NOT copy the files to "js"-folder where they already are.