thirtybees / niara

Niara, thirty bees default theme since v1.1.0.
https://thirtybees.com
9 stars 25 forks source link

Can't translate button's string #38

Closed wartinw closed 4 years ago

wartinw commented 4 years ago

in /niara/blob/master/modules/beesblogrecentposts/views/templates/hooks/home.tpl Line 51 is: <p><a class="btn btn-primary" href="{$post->link|escape:'htmlall':'UTF-8'}" title="{$post->title|escape:'htmlall':'UTF-8'}">Read More</a></p>

but should be: <p><a class="btn btn-primary" href="{$post->link|escape:'htmlall':'UTF-8'}" title="{$post->title|escape:'htmlall':'UTF-8'}">{l s='Read More' mod='beesblogrecentposts'}</a></p>

In /niara/blob/master/modules/beesblogrelatedproducts/views/templates/hooks/product.tpl

Line 42 is: <p><a class="btn btn-primary" href="{$post.link|escape:'htmlall':'UTF-8'}" title="{$post.title|escape:'htmlall':'UTF-8'}">Read More</a></p>

Should be: <p><a class="btn btn-primary" href="{$post.link|escape:'htmlall':'UTF-8'}" title="{$post.title|escape:'htmlall':'UTF-8'}">{l s='Read More' mod='beesblogrelatedproducts'}</a></p>

Same in these files: beesblogpopularposts/views/templates/hooks/home.tpl beesblogpopularposts/views/templates/hooks/product.tpl beesblogrecentposts/views/templates/hooks/product.tpl

wartinw commented 4 years ago

Hi. I was trying to make a branch, fix the code and make a pull request. Could you give permission? Is it possible? Thanks!

getdatakick commented 4 years ago

You need to fork the repository first. Then commit and push your changes to your repository. After that, you can go to original/this repository and create pull request from your repo.

No permissions needed.

wartinw commented 4 years ago

Thanks, I did it that way.