search

thirtybees / psonesixmigrator

PrestaShop 1.6 to thirty bees migrator
Academic Free License v3.0
4 stars 6 forks source link

Disabling PS modules leads to confusion #7

Closed musicpanda closed 5 years ago

musicpanda commented 7 years ago

During the migration TB disables all non-TB modules. This is in line with Prestashop disabling all non-Prestashop modules during an upgrade.

However, all non-TB modules means also all Prestashop modules. And as the upgrade does not replace modules with their ThirtyBees equivalent this means that almost all modules are replaced. The result is a completely dysfunctional website that easily leads to the conclusion that the upgrade has gone wrong. Even such basics as the footer are missing.

So my proposal is either to replace some PS modules with their TB equivalent or to treat some PS modules as TB modules.

musicpanda commented 7 years ago

The need for upgrades applies extra for the Blockrss module that produces a warning in the backoffice: thirty8

firstred commented 7 years ago

Even the latest version of the blockrss module? We've removed the previous blockrss module as it uses a library that doesn't support PHP 7.0+, so it has to be removed asap.

firstred commented 7 years ago

Replaced*

firstred commented 7 years ago

So my proposal is either to replace some PS modules with their TB equivalent or to treat some PS modules as TB modules.

Good catch, thanks! Hadn't thought of that actually. The first idea was to disable all non-tb stuff, but that indeed includes PS modules. Since most of those modules have tb equivalents it is probably best to immediately swap them with the thirty bees ones, but that's got to be tested first

musicpanda commented 7 years ago

I assume it was still the Prestashop RSS module.

Traumflug commented 5 years ago

Not sure when it was fixed, but native modules get recognized by name for quite a while now: https://github.com/thirtybees/thirtybees/blob/1.0.x/classes/module/Module.php#L1210-L1215 (core code, which is synchronized with module code). This should remove the distinction by module author.

In case the issue persists, please don't hesitate to open another issue.