search

thirtythreeforty / bullycpp

A Bully Bootloader PC driver program
GNU General Public License v3.0
12 stars 6 forks source link

Hard to see that the lock button is down #18

Closed thirtythreeforty closed 8 years ago

thirtythreeforty commented 8 years ago

The lock button should change from an unlocked padlock to a locked one. This will make it easier to see on Windows 10, where the OS merely shades the button a little.

vidavidorra commented 8 years ago

I've got the source files today, since I've got the day off from school :laughing:.
So I was playing around with the lock icon for a bit and created the icon below as unlocked padlock. I've added it to the resource file and added it to standard at the StickyQButton. So now the icon of the padlock is standard the open padlock and when pressed (the button is released) it changes to the locked padlock again.
The only downside to this is that the unlocked padlock is 2 pixels higher that the unlocked padlock, thus resulting in the padlock is using up the complete 16 pixels in hight. Therefore I had to move the locked padlock down one pixel as well.
So the padlock is very close to the edge of the actual button. See the example below.
Personally I think it would look nicer if the lock was one more pixel away from the edge of the button, but that would result in a smaller lock. So I think it's better to have the lock close to the edge than to have a smaller lock. I would like to hear your thoughts about this.

New png files:

lock1_closed lock_open

Examples:

Unlocked state image Locked state image

What do you think of it? If you like it I could do a pull request or hand over the adjusted image files and settings. Just let me know!

thirtythreeforty commented 8 years ago

Very nice!

I actually think you could get the best of both worlds regarding the padding by using the original image for the locked lock. This would make the lock shift up and down when clicked, but I think that would just provide more visual feedback and look fine.

The other option is to just erase some of the pixels to indicate an unlocked lock (not making it any taller), but I like having the shackle pop up as you have it now.

If you want to open a pull request, that would be great!