search

thisandagain / fastly

Fastly API client for Node.js
MIT License
70 stars 28 forks source link

Promise support #43

Open zeke opened 5 years ago

zeke commented 5 years ago

Hello @thisandagain! Long time no see. 👋

This module is handy, but it would be more ergonomic in our new async/await world if it supported Promises. I'd be happy to open a PR for this but want to see first if this module is maintained, and if such a change would be welcomed.

thisandagain commented 5 years ago

Hey @zeke! :wave:

This module is still used in production by our team, but I haven't had much reason to make changes. Happy to accept a PR adding support for promises.

zeke commented 5 years ago

Nice! Question: Would you be open to a new major version (breaking change) that only supports Promises? Or is it important to continue supporting both?

thisandagain commented 5 years ago

It would be ideal to support both, but I'm certainly open to a major version bump that only supports promises.