Fix erroneous URL encoding of query parameters

thisbejim / Pyrebase

A simple python wrapper for the Firebase API.

2.05k stars 525 forks source link

Fix erroneous URL encoding of query parameters #389

Open tejasvi opened 2 years ago

tejasvi commented 2 years ago

quote is redundant since we anyway urlencode(parameters) at the end.

AlfonsoAgAr commented 2 years ago

I didn't see that there was someone who had this same problem. #393

I tried your solution and it works.

tejasvi commented 2 years ago

Actually the double encoding relies on previously buggy behavior of REST API which decodes twice. https://github.com/firebase/firebase-admin-python/issues/189. State of python client is dismal. Admin SDK has various bug fixes and perf improvements while only pyrebase supports client authentication. Looks like I'll be migrating to Node.js in future, though PubNub looks promising for now.