Open N0tExisting opened 7 months ago
Appreciate this, since even just taking the sortable list example and rendering 1000 items makes this library unbearably slow.
I built out on this and added a bunch more memoisation and some performance optimisation where I saw using the chrome performance devtools that time was spent, my work is here: https://github.com/danieltroger/faster-solid-dnd/commits/main/, mainly this commit: https://github.com/danieltroger/faster-solid-dnd/commit/020c07fa8759057ac3d869f492081a416c7c180e
Seems like this lib looks umaintained anyways so I won't bother anymore trying to upstream my changes (for now).It's still too slow, mostly due to the solid stores being slow - dragging around, multiple seconds are spent in there. With no low hanging fruits spotted I'll look for other solutions (was just exploring this lib)
Thanks for taking a look. I think virtualisation support would be the way forward to deal with larger numbers of items.
This PR fixes overly eager execution of effects in components
Updates:
colision.ts
combine-refs.ts
create-dragable.ts
create-dropable.ts
create-pointer-sensor.ts
create-sortable.ts
drag-drop-context.tsx
drag-drop-debugger.tsx
drag-drop-sensors.tsx
drag-overlay.tsx
index.tsx
layout.ts
move-array-item.ts
sortable-context.tsx
style.ts