search

thisbeyond / solid-dnd

A lightweight, performant, extensible drag and drop toolkit for Solid JS.
https://solid-dnd.com
MIT License
516 stars 34 forks source link

fix: properly shuffle around sortables when draghandle is separate div #111

Open CallumJHays opened 5 months ago

CallumJHays commented 5 months ago

Hi, thanks for all your work on this awesome library!

I tried implementing the separate drag handler with sortable as described in #84, but I noticed that the sortables weren't shuffling around as I dragged it around anymore. I think I narrowed down the problem, with a fix that I've included in this PR.

Before: ezgif-7-21591bd13f

After: ezgif-7-d7cc2cf7d2

Let me know if there's anything you'd like to change about the implementation, or feel free to edit it yourself. I'm not the most attentive to github notifications, but I'll try my best to respond 😅

martinpengellyphillips commented 5 months ago

Oh, interesting. I'll take a closer look at this next week and see about merging it in. Thanks!