search

thisdot / open-source

Repository for open source packages
MIT License
34 stars 11 forks source link

Release tags are on detached commits #101

Open TapaiBalazs opened 2 years ago

TapaiBalazs commented 2 years ago

When we run the release pipeline, it pushes up the tags to github, but the commits that increase the version number in the package.json file are not part of the main branch. Cherry-picking them won't change the link of the tags.

I imagine what we would need to do in the release pipeline is to open a branch, where the pipeline can commit and push it up, and then open a PR to the main branch that we can merge automatically.

TapaiBalazs commented 2 years ago

I was able to create a PR with the commit pushed, but I encountered 2 problems:

  1. The PR checks didn't run at all
  2. When I squash merged it, the tag was not merged