Chore/vue showcase route guard cypress test

thisdot / open-source

Repository for open source packages

MIT License

35 stars 11 forks source link

Chore/vue showcase route guard cypress test #128

Closed temitopeadesoji closed 2 years ago

temitopeadesoji commented 2 years ago

Bug

Added cypress test for route-guard showcase
Added test command to CI

closes #125

TapaiBalazs commented 2 years ago

Please add a closes #issueNumber to the PR so the related issue gets closed when this gets merged

temitopeadesoji commented 2 years ago

Please see my comments.

Do these tests cover everything?

What about the following situation: 0. The route-guard is set up so the user is logged in

The user opens a guarded endpoint initially

The page loads without any redirects

added "The user opens a guarded endpoint initially" test case and also updated some of the previous test titles as i feel they cover the other 2 tests you suggested

temitopeadesoji commented 2 years ago

@TapaiBalazs I have updated this PR.