feat: adds auto generate showcases

thisdot / starter.dev

A collection of kits to help bootstrap your next project.

https://starter.dev

MIT License

132 stars 16 forks source link

feat: adds auto generate showcases #1296

Closed WillHutt closed 1 year ago

WillHutt commented 1 year ago

Type of change

[x] Feature
[ ] Documentation change
[ ] Bug fix

Summary of change

Auto generates showcases based on package.jsons
Refactored the original kit to generate script

Checklist

[x] These changes follow the contributing guidelines
[x] This starter kit has been approved by the maintainers
[ ] Changes for this new starter kit are being pushed to an integration branch instead of main
[x] All dependencies are version locked
[ ] This fix resolves #1292
[x] I have verified the fix works and introduces no further errors

netlify[bot] commented 1 year ago

Deploy Preview for starter-dev ready!

Name	Link
Latest commit	72fe6ac1e393bf6d21ca0be0946e53e780da55ae
Latest deploy log	https://app.netlify.com/sites/starter-dev/deploys/64af2faa83057c00080c484b
Deploy Preview	https://deploy-preview-1296--starter-dev.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

WillHutt commented 1 year ago

Yeah, I was initially planning on #1291 being merged before this was completed, but that had a few rounds of changes and is still ongoing.

I was considering pushing this into #1291, but I also didn't want to hold that up with any feedback on this and cause a massive delay on it like in previous PRs/tickets.

With that route chosen, I ended up removing the hook-up functionality I had originally implemented for instance

The lib/parseKits adjustments
Removal of the showcase variable from the config file
The icon being handled since that isn't set in the package.json

I was going to create a new ticket that would focus on combining those above-needed changes with the new updates from #1291.

I'm good with either outcome and I will be pushing a new commit that should address a majority of the feedback you've given. 😄

lindakatcodes commented 1 year ago

@WillHutt The design changes from #1291 is now merged into main! You should be good to rebase this PR when you come back and move forward from there. 👍🏼