[svelte-kit-scss] jest-dom types are missing#1204 - Githubissues

thisdot / starter.dev

A collection of kits to help bootstrap your next project.

https://starter.dev

MIT License

132 stars 16 forks source link

[svelte-kit-scss] jest-dom types are missing#1204 #1298

Closed ihardz closed 1 year ago

ihardz commented 1 year ago

Type of change

[ ] Documentation change
[x] Bug fix

Summary of change

Typehint errors on jest-dom related assertions, IDE should understand calls like .toBeInTheDocument

Types for jest-dom should be added to TypeScript
"types": ["node", "jest", "@testing-library/jest-dom"]
This also needs the @types/testing-library__jest-dom package to be installed.

Checklist

[x] These changes follow the contributing guidelines
[x] This starter kit has been approved by the maintainers
[x] Changes for this new starter kit are being pushed to an integration branch instead of main
[x] All dependencies are version locked
[x] This fix resolves #1204
[x] I have verified the fix works and introduces no further errors

netlify[bot] commented 1 year ago

Deploy Preview for starter-dev canceled.

Name	Link
Latest commit	5794e954dc4c71eadc47e02f76fb712bf1a181a3
Latest deploy log	https://app.netlify.com/sites/starter-dev/deploys/64b47702738e820008657142

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication