[WIP] Working on Temporal Filter

thisisashukla / sos-client

An SOS Client for NDBC

https://git-ankur-shukla.github.io/SOSClient/.

0 stars 1 forks source link

[WIP] Working on Temporal Filter #7

Closed thisisashukla closed 6 years ago

thisisashukla commented 6 years ago

This PR solves #4 partially. Work in progress, kindly don't merge

thisisashukla commented 6 years ago

Added a new variant of temporal filtering function in 83517af. Got some help from the answer in #889

References:

[X] iconCreateFunction - for counting number based on custom properties
[X] _defaultIconCreateFunction - for maintaining default icon style

@omshinde @pan111 need your suggestions on this one. Which one to keep and which one to discard

thisisashukla commented 6 years ago

as per feedback from @omshinde and @pan111 i am keeping the enabled property on but implementing logic to remove markers as of now. we can later have another discussion on weather to have disabled markers on screen or to remove them.

thisisashukla commented 6 years ago

The last commit to this PR completes the temporal filter.