search

thisisparker / xword-dl

⬛⬜⬛ Command line tool to scrape crosswords from online solvers and save them as .puz files ⬛⬜⬛
MIT License
140 stars 30 forks source link

Circles not parsed by CrosswordCompiler Downloader #103

Closed thisisparker closed 1 year ago

thisisparker commented 1 year ago

E.g. the 3/18/23 Modern Crossword has circles that are not encoded into the resulting .puz

boisvert42 commented 1 year ago

I just opened a PR for this

thisisparker commented 1 year ago

Wow, awesome, thank you! I definitely had just opened this issue to remind myself to fix it, but this is even better :)

I've got a few open PRs that I think are just about ready to merge, so I'll cut a release soon and make sure this is in there. Thanks again!

boisvert42 commented 1 year ago

I don't think this violates my blood oath not to work on puz files anymore

On Sun, Mar 19, 2023, 6:35 PM Parker Higgins @.***> wrote:

Wow, awesome, thank you! I definitely had just opened this issue to remind myself to fix it, but this is even better :)

I've got a few open PRs that I think are just about ready to merge, so I'll cut a release soon and make sure this is in there. Thanks again!

— Reply to this email directly, view it on GitHub https://github.com/thisisparker/xword-dl/issues/103#issuecomment-1475485701, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRTVHZC6R5FC4FPDVNCFRLW46X43ANCNFSM6AAAAAAV7XJGU4 . You are receiving this because you commented.Message ID: @.***>

thisisparker commented 1 year ago

Closed by #104, now shipped