search

thisisparker / xword-dl

⬛⬜⬛ Command line tool to scrape crosswords from online solvers and save them as .puz files ⬛⬜⬛
MIT License
140 stars 30 forks source link

fix McKinsey crossword downloader #114

Closed iNtEgraIR2021 closed 10 months ago

iNtEgraIR2021 commented 11 months ago

As the title reads this PR fixes a bug caused by changes in the DOM tree of the McKinsey site.

thisisparker commented 10 months ago

Thanks for the PR! In checking it out I realized that the existing date-mapping approach would fail for days before the 10th of each month, as %d has a leading zero. (Note that we can't just use %-d because that doesn't work on Windows.)

In fixing that I realized that we always want the month name from an English locale, so in this case it's probably simplest to just write out the list. Please let me know if this works for you and I'll merge it in!

iNtEgraIR2021 commented 10 months ago

nice catch! 👍🏼 I successfully tested the commit. should be good to merge by now