search

thisisparker / xword-dl

⬛⬜⬛ Command line tool to scrape crosswords from online solvers and save them as .puz files ⬛⬜⬛
MIT License
145 stars 31 forks source link

New Yorker: Add theme title to Friday puzzles #119

Closed thisisparker closed 1 year ago

thisisparker commented 1 year ago

Fixes #111.

@edsantiago, would love if you could take a look at this and make sure it meets your needs! Two sort of compromise-y elements is that it uses the description field (which seems stable and a little easier to target than the subhed) and it loads a little more logic into the pick_filename function, but that seemed to be the best way to preserve existing behavior where desired and push out past it for this feature.

edsantiago commented 1 year ago

Would love to give it a try, but I no longer have a working build environment. All attempts now fail with Getting requirements to build wheel and I'm just about out of time for the weekend. I really appreciate your time.

edsantiago commented 1 year ago

With the diff below, everything builds perfectly, and xword-dl tny 8/25/23 brings in a Friday themed crossword with a lovely title! LGTM, thank you!

diff --git a/requirements.txt b/requirements.txt
index 44858a2..ef6eb82 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -7 +7 @@ Unidecode==1.3.6                                                   
-pyyaml==6.0
+pyyaml==6.0.1