search

thisisparker / xword-dl

⬛⬜⬛ Command line tool to scrape crosswords from online solvers and save them as .puz files ⬛⬜⬛
MIT License
146 stars 31 forks source link

Added downloader for the daily WaPo puzzle #179

Closed afontenot closed 9 months ago

afontenot commented 9 months ago

The downloader for WaPo previously only downloaded the Sunday edition.

The existing 'wp' command is renamed to 'wps', reflecting that it downloads the Sunday edition of the puzzle.

afontenot commented 9 months ago

In case it's unclear, the Washington Post has two Sunday puzzles. The Sunday edition downloader only handles the Sunday exclusive puzzle by Evan Birnholz, the daily puzzle series (which includes a Sunday puzzle) is by a variety of contributors.

thisisparker commented 9 months ago

Hello there! Thank you for the contribution!

I may be mistaken, but I think the "daily" Washington Post puzzle is syndicated from the LA Times. If that's the case, I think I have a preference for not creating a second code path to get the same puzzle. But it's totally possible I'm missing something or there's a reason to have it here too! What do you think?

afontenot commented 9 months ago

Looks like you're right, I never realized this. Whoops.

I think I'll close the PR, but maybe it would be reasonable to change the Washington Post downloader to have the outlet read "Washington Post Sunday" or something like that?

thisisparker commented 9 months ago

Yes, I will think about how to add that clarity! In the meantime, I've structured this package with the separate downloaders so that it's relatively easy to maintain a fork with the expanded WP downloader if you want to for any reason