search

thisisparker / xword-dl

⬛⬜⬛ Command line tool to scrape crosswords from online solvers and save them as .puz files ⬛⬜⬛
MIT License
147 stars 32 forks source link

Add some flexibility to how xword-dl saves files #43

Closed blandford closed 2 years ago

blandford commented 2 years ago

This will let you save into other directories (eg. 'xword-dl -o /tmp/temp.puz') as well as let you output the .puz file directly to stdout.

thisisparker commented 2 years ago

Lol also can you tell I have no idea how to work Github

blandford commented 2 years ago

Hey Parker,

I see what you mean by wanting to guard against '/' characters. I moved the call to remove invalid chars to just remove the fields from the puzzle, before we do the substitution. That will guard against unexpected (and potentially problematic) shell characters, but still permit intended ones.

If someone wants to call the output file /tmp/<>"|?*.puz I suppose we should let them!!?

blandford commented 2 years ago

Just a friendly reminder on this issue. I'm hoping you can get this into the next release, when it happens.

thisisparker commented 2 years ago

thanks for the PR, and sorry it took so long for me to merge it in! I'm planning to cut a release soon and this will now be included :)