search

thislooksfun / earthdawn

A smart Earthdawn character sheet
GNU General Public License v2.0
0 stars 1 forks source link

An in-range update of snyk is breaking the build 🚨 #98

Closed greenkeeper[bot] closed 5 years ago

greenkeeper[bot] commented 5 years ago

The devDependency snyk was updated from 1.246.0 to 1.247.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

snyk is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details - ❌ **unit-tests (12.x):** There are 2 failures, 0 warnings, and 0 notices. - ❌ **unit-tests (10.x):** There are 1 failures, 0 warnings, and 0 notices.
Release Notes for v1.247.0

1.247.0 (2019-11-13)

Features

Commits

The new version differs by 4 commits.

  • e69ef82 Merge pull request #861 from snyk/feat/introduce-jar-files
  • e699598 feat: add *.war support
  • 0189a39 chore: split up test and monitor tests
  • e845d19 feat: detect *.jar files as maven

See the full diff

FAQ and help There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

greenkeeper[bot] commented 5 years ago

After pinning to 1.246.0 your tests are passing again. Downgrade this dependency 📌.

thislooksfun commented 5 years ago

The update didn't break any tests, it was a build system failure—specifically, when attempting to run npm install it errored saying it couldn't find snyk@1.247.0. Re-running just now caused the checks to succeed. Thus, closing in favor of #99.