thismarvin / relatus

morro but better
MIT License
1 stars 0 forks source link

RectangleF GetResolution takes an XNA Rectangle #7

Closed thismarvin closed 3 years ago

thismarvin commented 3 years ago

It should take a RectangleF!

thismarvin commented 3 years ago

Fixed, but I feel like there should be a way to use a normal Rectangle with RectangleF. Maybe add an extension to Rectangle to convert to a RectangleF? Or vice versa?

thismarvin commented 3 years ago

Well yeah this was already fixed, but moving forward I think Rectangle should be avoided at all costs... They are no longer compatible. If anything, there could be like a ConvertToRectangleF method if necessary, but probably not the other way around.