search

thliebig / openEMS-Project

openEMS is a free and open electromagnetic field solver using the FDTD method.
356 stars 65 forks source link

Changed Submodules to instead use the github repos #129

Closed AbleArcher88 closed 6 months ago

AbleArcher88 commented 8 months ago

I have changed the submodules in .gitmodules to use the git repos instead of what you were doing before. using this, I created a PKGBUILD

thliebig commented 8 months ago

Can you explain why you want to replace the relative submodule paths with absolute ones? This does not look like a good idea to me as this would make forking or hosting somewhere else impossible?

AbleArcher88 commented 8 months ago

Can you explain why you want to replace the relative submodule paths with absolute ones? This does not look like a good idea to me as this would make forking or hosting somewhere else impossible?

I did this because it wasn't working with makepkg. Whenever i tried to run 'git submodule update --init' it wouldn't work. It would claim it couldn't find the submodules.

thliebig commented 8 months ago

Well sounds to me that you have to solve that issue on your end, e.g. by using a patch file in your PKGBUILD. I don't think that this change is good for the project as it is...

thliebig commented 6 months ago

Well I still do not think this is the correct approach. If you/anyone disagrees, please reopen