Closed oberstet closed 8 months ago
Is this PR complete and ready to review? Should I merge this maybe squashed as this are many commits for not that a big changes?
yes, it's ready for review / merge - I have tested this and I am running this now for my ongoing work. but only on latest CPython / Cython, not any older/other versions.
rgd squashing and such: sure! I wasn't sure about test and merge policies of this project. I am fine with any commonly used policies, such as "every commit preserved", "squashed all commits" and "squashed and rebased to master always required" ..
sidenote: would there be interest in principle for a) adding test automation to the repo (via GH actions), and b) release a proper Python package (or multiple) on PyPI? the lack of the latter is a bit of a annoyance as I always automate my own packages, but this depends on the former. btw: actually, test+build+publish automation (that is CI and CD) for PyPI and Docker images would be nice. if there is interest .. I could contribute .. I have a lot of experience with such stuff.
another note rgd PyPI: not having an official package on PyPI entails the (security) risk of name squatting. none there yet though https://pypi.org/search/?q=openems
Well I do not really have any "merge policy" at this time. I just decide on what I feel is the best for the project. Your commits have proper messages and are not going crazy with adding/removing/adding back such in this case both normal merge and squash would be fine with me I guess.
Regarding the github actions/auto tests I would be all for it, but I do not think that it is too easy to do in this case? But maybe a few people have already something available. In any case it would be nice to have.... (maybe this should better be a separate Discussion thread?)
Having proper PyPI packages again would be very nice, but again because of all this cython/library/mix with CSXCAD not that easy?? (again worth a separate Discussion thread?)
again worth a separate Discussion thread?
yes, agreed, definitely. only the openEMS-Project repo has discussion enabled, so I posted there https://github.com/thliebig/openEMS-Project/discussions/166
tested on cpython 3.12.1 and cython 3.0.6: