Gave Parse_XML_FDTDSetup a return value

thliebig / openEMS

openEMS is a free and open-source electromagnetic field solver using the EC-FDTD method.

http://openEMS.de

GNU General Public License v3.0

449 stars 154 forks source link

Gave Parse_XML_FDTDSetup a return value #24

Closed georgmichel closed 7 years ago

georgmichel commented 7 years ago

Now with the current version of openems.cpp

BTW: MPI was tested on an AWS cluster. Without the fix only one split per coordinate was possible. Now it works fine for me, tested also SimplePatch tutorial.

thliebig commented 7 years ago

I'm not quite sure what I should do with this commit. It only adds the single return statement? Can you please create just one patch/commit with your MPI fixes and all without the removed bug fix? If you like I can just do it myself, by amending your first pull request on this topic (#23) ... Whatever you prefer. I personally just would not like to reintroduce the bug to refix it again. Maybe I'm just a little bit overly picky with my git tree, but hey, I can't help it ;)

thliebig commented 7 years ago

See #25