thliebig / openEMS

openEMS is a free and open-source electromagnetic field solver using the EC-FDTD method.
http://openEMS.de
GNU General Public License v3.0
448 stars 152 forks source link

Fix octave #50

Closed andypfau closed 5 years ago

andypfau commented 5 years ago

Fixed verification of arguments in some Octave scripts

Fixed typos in several Octave scripts

andypfau commented 5 years ago

Added another fix: when openems.exe exits with non-zero, it propagates the error; before this, it just silently crashed, making it very hard to deiagnose crashes

thliebig commented 5 years ago

Looks all good so far. Two questions only:

andypfau commented 5 years ago

Yeah, good point.... don't ask me why I was thinking Windows...

I don't know what's odd about my e-mail address, I guess you meant because it was not shown at all?

thliebig commented 5 years ago

With user and email being odd, I mean that the commits say this: Author: Andy <andy@desktop.fritz.box>

andypfau commented 5 years ago

Ah that... yes I realized this, and fixed it, unfortunately too late. Only my last commit was done with the correct user config, the three older ones were with the global user config that git gratefully guessed for me.

I fail to find the location where those names are displayed. Help me please. If it is correct now, fine, otherwise I'd just commit the changes again with the correct user config.

thliebig commented 5 years ago

Well just do git log or gitk shows it too. I don't know which tool you use, but me on Linux its terminal only of course ;)

thliebig commented 5 years ago

And no the last commit is the same as the other three

andypfau commented 5 years ago

Nah I'm not religious about that... but as a matter of fact I use git from the shell, I just could not see it anywhere on GitHub.

But okay, I messed up my config, I start over, and ignore this pull request.

andypfau commented 5 years ago

See pull request #51