Closed khashabri closed 5 years ago
Hi guys, in the RCS sphere tutorial, some math functions such as sin(x) and cos(x) are used. https://github.com/thliebig/openEMS/blob/ffcf5ee0a64b2c64be306a3154405b0f13d5fbba/python/Tutorials/RCS_Sphere.py#L62 The parameter x should be in radiant as it is mentioned here. However, in the code implementation, these functions get an argument in degree which is false. https://github.com/thliebig/openEMS/blob/ffcf5ee0a64b2c64be306a3154405b0f13d5fbba/python/Tutorials/RCS_Sphere.py#L29 Please note that exceptionally this example works, because 0 degree is equal to 0 radiant. If you choose any other angle you will get a wrong result. The correct implementation would be: k_dir = [cos(inc_angle*2*pi/360), sin(inc_angle*2*pi/360), 0] in the line 62.
sin(x)
cos(x)
x
k_dir = [cos(inc_angle*2*pi/360), sin(inc_angle*2*pi/360), 0]
Hi guys, in the RCS sphere tutorial, some math functions such as
sin(x)andcos(x)are used. https://github.com/thliebig/openEMS/blob/ffcf5ee0a64b2c64be306a3154405b0f13d5fbba/python/Tutorials/RCS_Sphere.py#L62 The parameterxshould be in radiant as it is mentioned here. However, in the code implementation, these functions get an argument in degree which is false. https://github.com/thliebig/openEMS/blob/ffcf5ee0a64b2c64be306a3154405b0f13d5fbba/python/Tutorials/RCS_Sphere.py#L29 Please note that exceptionally this example works, because 0 degree is equal to 0 radiant. If you choose any other angle you will get a wrong result. The correct implementation would be:k_dir = [cos(inc_angle*2*pi/360), sin(inc_angle*2*pi/360), 0]in the line 62.